Skip to content

PD-5749 Fix ext ids display on activities #2869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amontenegro merged 3 commits into from
Jun 24, 2026
Merged

PD-5749 Fix ext ids display on activities #2869

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1458c43
PD-5749 Fix ext ids display on activities
amontenegro Jun 23, 2026
bccf40a
PD-5749 run lin
amontenegro Jun 23, 2026
3799752
Merge branch 'main' into amontenegro/PD-5749-2
amontenegro Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/assets/print-view/fetch-orcid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,9 +441,10 @@ function otherIdsTextNode(label, value, url) {
wrapper.appendChild(prefix)
}

const safeUrl = sanitizeUrl(url)
const valueAsUrl = sanitizeUrl(value)
if (valueAsUrl) {
// If the value itself is a URL, render it as a link and ignore the `url` parameter
if (safeUrl && valueAsUrl) {
// If both are provided and value is a URL, render value as the link
wrapper.appendChild(document.createTextNode(' ('))
const a = document.createElement('a')
a.href = valueAsUrl
Expand All @@ -453,10 +454,10 @@ function otherIdsTextNode(label, value, url) {
wrapper.appendChild(a)
wrapper.appendChild(document.createTextNode(')'))
} else {
// Otherwise, keep the existing behavior: render value as text,
// Otherwise, render value as text,
if (value) wrapper.appendChild(document.createTextNode(value))

// and optionally append a (url) link if provided and safe
wrapper.appendChild(document.createTextNode(value))
const safeUrl = sanitizeUrl(url)
if (safeUrl) {
wrapper.appendChild(document.createTextNode(' ('))
const a = document.createElement('a')
Expand Down Expand Up @@ -570,9 +571,7 @@ function composeActivityEntryFromJson(entry, opts = {}) {
idRel && idRel.toLowerCase() !== 'self'
? `${localizedRel} ${idType}`.trim()
: idType || STRINGS.identifier
wrapper.appendChild(
otherIdsTextNode(label, idValue || idUrl || '', idUrl)
)
wrapper.appendChild(otherIdsTextNode(label, idValue, idUrl))
})
}

Expand Down
Loading