Merged
Conversation
Collaborator
Author
|
@sethrj -- please proceed |
Member
|
Still seems to have the other branch? |
Collaborator
Author
|
@sethrj The rebase command above only showed me commits that were not in your branch or PR and those were the ones I picked...you should only see new commits since after the debug session. |
sethrj
reviewed
Jul 16, 2025
load_module changes will be pushed there once this branch is merged
sethrj
requested changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the function
from_bytesthat creates a memory buffer for in-memory IR, parses the IR string content, and returns a Module. A simple test is included to read QIR files from thetest/datafolder, parse it to a string, and send it tofrom_byteswithout throwing an error.