Skip to content

Add in-memory IR parser#39

Merged
sethrj merged 18 commits intoORNL-QCI:mainfrom
wongey:qiris.cqiree
Jul 17, 2025
Merged

Add in-memory IR parser#39
sethrj merged 18 commits intoORNL-QCI:mainfrom
wongey:qiris.cqiree

Conversation

@wongey
Copy link
Copy Markdown
Collaborator

@wongey wongey commented Jul 15, 2025

This PR introduces the function from_bytes that creates a memory buffer for in-memory IR, parses the IR string content, and returns a Module. A simple test is included to read QIR files from the test/data folder, parse it to a string, and send it to from_bytes without throwing an error.

@wongey wongey added the enhancement New feature or request label Jul 15, 2025
@wongey wongey requested a review from sethrj July 15, 2025 19:01
Copy link
Copy Markdown
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this accidentally contains #30; could you please fix and then I'll continue reviewing?

@wongey
Copy link
Copy Markdown
Collaborator Author

wongey commented Jul 16, 2025

@sethrj -- please proceed

@wongey wongey requested a review from sethrj July 16, 2025 18:48
@sethrj
Copy link
Copy Markdown
Member

sethrj commented Jul 16, 2025

Still seems to have the other branch?

@wongey
Copy link
Copy Markdown
Collaborator Author

wongey commented Jul 16, 2025

@sethrj The rebase command above only showed me commits that were not in your branch or PR and those were the ones I picked...you should only see new commits since after the debug session.

load_module changes will be pushed there once this branch is merged
@wongey wongey requested a review from sethrj July 17, 2025 13:50
@wongey wongey requested a review from sethrj July 17, 2025 21:01
Copy link
Copy Markdown
Member

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sethrj sethrj enabled auto-merge (squash) July 17, 2025 21:09
@sethrj sethrj merged commit 8c6f410 into ORNL-QCI:main Jul 17, 2025
3 checks passed
@wongey wongey deleted the qiris.cqiree branch July 21, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants