Experiment validation - #93
Draft
WarmCyan wants to merge 1 commit into
Draft
Conversation
Member
|
@WildfireXIII I see where you added the check flag but not any code using it in other portions of curi. Are you still working on that part? |
Collaborator
Author
|
Yeah I haven't really progressed any on this, this feature will likely take a while to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address #81, the idea is to have a
--checkflag that, similar to--map, doesn't actually run the experiment, but it will run various checks for basic correctness and provide various stats about how it would run.