remove queues from auto_queues using {Allow,Deny}Qos #4471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
reviewed
Jul 15, 2025
simonLeary42
force-pushed
the
remove-auto-queues-allowqos-denyqos
branch
from
59d4821 to
1608111
Compare
simonLeary42
force-pushed
the
remove-auto-queues-allowqos-denyqos
branch
2 times, most recently
from
580a13c to
1608111
Compare
Bubballoo3
added
status/awaiting review
simonLeary42
commented
Sep 30, 2025
| return false if queue.allow_accounts && !queue.allow_accounts.include?(account.to_s) | ||
| return false if queue.deny_accounts.include?(account.to_s) | ||
| return false if queue.allow_qos && !(queue.allow_qos & account.qos).any? | ||
| return false if (queue.deny_qos & account.qos).any? |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| return false if (queue.deny_qos & account.qos).any? | |
| return false if account.qos.difference(queue.deny_qos).none? |
Contributor
Author
There was a problem hiding this comment.
I think this was wrong. If you have 3 QoS and one of those are denied, you still have access via the other 2 QoS. Only if all of your account's QoS denied should the account be considered denied.
Contributor
Author
|
TODO can we set |
johrstrom
reviewed
Dec 8, 2025
| # This behavior is replicated in OOD Core by conditionally setting deny_qos to an empty array. | ||
| return false if queue.allow_accounts && !queue.allow_accounts.include?(account.to_s) | ||
| return false if queue.deny_accounts.include?(account.to_s) | ||
| return false if queue.allow_qos && (queue.allow_qos & account.qos).none? |
Contributor
There was a problem hiding this comment.
This line is always being returned in the test cases. Somehow the computation of qos is off.
Contributor
|
Hey, we are putting this on hold for now while we finish up the next release, and will revisit it after the new year. The deadline for external contributions has passed for 4.1, so we will get back to you with reviews once we wrap this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3932
relies on OSC/ood_core#888
Also fixes a little inconsistency where
account_allowedtakes into accountdeny_accountsas well asallow_accounts, whileblocked_queueonly takes into accountallow_accounts.Confirmed working on my home system. Marked as draft until test cases can be written,
and I can explore the possibility of user<->partition associations in slurm.