Parent charts for CryoSPARC service #327
Conversation
| image: | ||
| tag: latest | ||
| ingress: | ||
| host: cryosciapps.osc.edu |
There was a problem hiding this comment.
Be good to add hostAlias here too for testing. Though I'd recommend using not OSC addresses, they don't need to be real as this CI folder is for automated tests that don't need to be accessible.
For testing locally you could do -f <path to this file> --set ingress.host=<osc address>
| {{- range $index, $node := $nodes.items }} | ||
| - ip: "127.0.0.{{ add $index 10 }}" | ||
| hostnames: | ||
| - {{ $node.metadata.name | quote }} | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
Shouldn't all the hostnames map to 127.0.0.1? That way they all resolve locally. So you'd just have ip: '127.0.0.1 and look under hostnames only.
| @@ -0,0 +1,195 @@ | |||
| apiVersion: apps/v1 | |||
| kind: Deployment | |||
There was a problem hiding this comment.
Shouldn't this be a stateful set? Isn't that what worked better in testing since CryoSPARC really can't run with multiple instances using same storage path?
| # Fix rollout restart issue | ||
| cryosparcm restart; | ||
| # Add Sciapps admin account |
There was a problem hiding this comment.
If you used a stateful set, this restart likely would not be needed but might still be needed to clear locks but hopefully not.
| rwDir: | ||
| project: /fs/ess/{{ .Values.project }} |
There was a problem hiding this comment.
I'd recommend get rid of rwDir and just call it project.
| rwDir: | |
| project: /fs/ess/{{ .Values.project }} | |
| project: /fs/ess/{{ .Values.project }} |
| roDir: | ||
| slurm_conf: /etc/slurm | ||
| socket: | ||
| munge_socket: /var/run/munge/munge.socket.2 |
There was a problem hiding this comment.
Similar idea, get rid of the roDir and socket.
| roDir: | |
| slurm_conf: /etc/slurm | |
| socket: | |
| munge_socket: /var/run/munge/munge.socket.2 | |
| slurm_conf: /etc/slurm | |
| munge_socket: /var/run/munge/munge.socket.2 |
If you want to keep roDir and rwDir for additional mounts, that's fine but for known mounts, don't need to use the extra key.
There was a problem hiding this comment.
The roDir and rwDir for webservices was because no mounts were "known" so we had to just allow essentially any RO or RW path. For this chart the main mounts are known so don't need the extra key.
The CryoSPARC parent charts are created based on the web service parent charts.