Add GDALLoadEsriCLRAsRAT() to load Esri .clr files as RAT#14629
Merged
Conversation
elpaso
reviewed
Jun 3, 2026
elpaso
left a comment
elpaso
left a comment
Collaborator
There was a problem hiding this comment.
Code looks good to me but is the PDF test related?
Member
Author
that commit has alreay done into master, and was there to avoid the PR to fail for unrelated reasons |
Collaborator
Can you add a test for the CLR as RAT method? |
Member
Author
this is tested by autotest/gdrivers/ehdr.py::test_ehdr_rat() |
rouault
force-pushed
the
GDALLoadEsriCLRAsRAT
branch
from
ca4e5b8 to
59cfc5e
Compare
Member
Author
That's indeed better engineering to unit test independently of the EHdr driver. Unit test added in 59cfc5e |
elpaso
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.