Skip to content

v.vol.rst: Fix Uninitialized Variable in user1.c #5608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ShubhamDesai
Copy link
Contributor

This pull request fixes issue identified by Coverity Scan (CID : 1208484)

@github-actions github-actions bot added vector Related to vector data processing C Related code is in C module labels Apr 30, 2025
Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a similar issue with file /vector/v.vol.rst/user3.c, please address that here too.

@nilason nilason added this to the 8.5.0 milestone May 8, 2025
@github-project-automation github-project-automation bot moved this to In Progress in GRASS GIS Security May 8, 2025
@nilason nilason self-assigned this May 8, 2025
@ShubhamDesai
Copy link
Contributor Author

There is a similar issue with file /vector/v.vol.rst/user3.c, please address that here too.

Done.

@nilason
Copy link
Contributor

nilason commented May 19, 2025

There is a similar issue with file /vector/v.vol.rst/user3.c, please address that here too.

Done.

That one is a roughly similar issue (CID 1208515), but not the one I had in mind, which is CID1208514. We should, this time leave 1208515, because if we set mmax we might end up with a negative array index with mmax - 1.

(Take a look at the status for 1208515, you may notice it is "Triaged". Under the "Triage History" section you may see this issue may be cause of a real bug, which might need a proper (what ever that will mean) solution.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C module vector Related to vector data processing
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants