grass.jupyter: fix TimeSeriesMap layer rendering #5632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you want me to review it, I can try tomorrow on a full computer, it's hard to follow the context only on mobile. If anyone else wanted to take a look instead it's fine too. |
To properly test it, you need to run some of the example notebooks, but maybe you don't need to do that, I tried to test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5304. It required larger changes, moving more code to the BaseSeriesMap class.
It also fixes rendering vector time series and newly enables to pass d.rast/d.vect variables to TimeSeriesMap.add_raster_series/add_vector_series for symbology.
I tested it with the doc/examples/notebooks.