Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a dedicated regression test suite for the 'i.his.rgb` module in GRASS. The tests are designed to validate the correctness of HIS to RGB conversion across multiple well-defined input cases and ensure that key functionalities behave as expected under controlled conditions.
Tests Included
test_grayscale
: Verifies that whensaturation = 0
, all three RGB bands match the intensity input. It confirms correct handling of grayscale logic.test_primary_colors
: Tests pure hue-to-RGB conversions at full intensity and saturation.test_mask_handling
: Confirms that the module respects raster masks by validating that only unmasked regions are processed.Looking forward to feedback.
The tests fail currently due to bugs in implementation. #5659