GUI: always show 'Close dialog on finish' option

[landam]

Currently an option to close the dialog

is shown only for tools which are producing some output data. It's seems to be like a bug. This option should be shown always. Compare eg. r.compress (no output) with r.buffer (raster output).

[petrasovaa]

This needs to be done in a different way, otherwise it's going to close dialogs that have text output that a user would want to inspect.

[landam]

@petrasovaa I agree with you. On the other hand, I think the checkbox Close dialog on finish should be shown for all tools. Current default value is false in the settings, so the dialogs are not closed automatically. Currently the checkbox is not shown for tools like r.compress and others which is wrong. We could hide the checkbox for tools which have file output defined like v.db.select, so tools for which we expect that they print something important to stdout. But it will not probably true for 100% tools. I think it's still better to show the checkbox for all tools. Current behaviour may be confusing for some user. For some tools the checkbox is shown, for some not.

[lindakarlovska]

@petrasovaa I agree with you. On the other hand, I think the checkbox Close dialog on finish should be shown for all tools. Current default value is false in the settings, so the dialogs are not closed automatically. Currently the checkbox is not shown for tools like r.compress and others which is wrong. We could hide the checkbox for tools which have file output defined like v.db.select, so tools for which we expect that they print something important to stdout. But it will not probably true for 100% tools. I think it's still better to show the checkbox for all tools. Current behaviour may be confusing for some user. For some tools the checkbox is shown, for some not.

I agree with showing this option for all cases of modules. Another thing is (which is not a part of this PR) which option should be checked on default - I can imagine having it as global settings - which means that when a user once checks Close dialog on finish, the settings will be applied globally so that other dialogs launched later will be automatically closed.