Skip to content

GUI: do not remove parameter value on dialog update event #5760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

landam
Copy link
Member

@landam landam commented May 23, 2025

Currently when map/input option is changed than also all depending widgets (layer, columns, where) are updated. It includes also setting value to an empty string.

Steps to reproduce

  1. Launch v.db.select map=schools where="TAG = '001'" --ui
  2. Change map option

-> where option is removed

Screencast.From.2025-05-23.16-03-35.mp4

This PR changes current behaviour

-> where option is kept

Screencast.From.2025-05-23.16-05-36.mp4

Backround reasons

@landam landam requested review from pesekon2 and petrasovaa May 23, 2025 20:49
@landam landam self-assigned this May 23, 2025
@landam landam added backport to 8.4 PR needs to be backported to release branch 8.4 GUI wxGUI related Python Related code is in Python labels May 23, 2025
@landam landam modified the milestones: 8.4.2, 8.5.0 May 23, 2025
@landam landam marked this pull request as draft May 25, 2025 13:53
@landam
Copy link
Member Author

landam commented May 25, 2025

@pesekon2 Also implemented for ColumnSelect:

Screencast.From.2025-05-25.10-18-27.mp4

@landam landam marked this pull request as ready for review May 25, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to 8.4 PR needs to be backported to release branch 8.4 GUI wxGUI related Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant