temporal: prohibit writing map timestamps across mapsets#7211
Open
Dasux wants to merge 2 commits intoOSGeo:mainfrom
Open
temporal: prohibit writing map timestamps across mapsets#7211Dasux wants to merge 2 commits intoOSGeo:mainfrom
Dasux wants to merge 2 commits intoOSGeo:mainfrom
Conversation
ninsbl
approved these changes
Mar 22, 2026
Member
ninsbl
left a comment
There was a problem hiding this comment.
Looks good to me. Have not tested if it completely fixes the issue. But it is an improvement in any case...
Contributor
Author
|
Thanks for the feedback, currently it does not work as intended... I'll get back to you after i append the changes to the other methods |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #3394
The problem was when registering a map like
lakes@PERMANENT, the temporal framework attempts to write timestamp data into the current mapset. This created an invalid map entry e.g,lakes@to_verifywithout the actual vector data.The reason was ... the function
write_timestamp_to_grass()is called without verifying that the map belongs to the current mapset.Fix made:
Added an additional condition in the function
update_absolute_time()... to verify if map is in its own mapset or not.Additional note:
I found multiple instances of
write_timestamp_to_grass... I've added the condition only in one of the methods... I wanted to confirm if this was the intended change required before proceeding with the other methods...