Changed flip angles in dce tutorial to list - #165
Merged
Conversation
ltorres6
approved these changes
Jul 23, 2026
ltorres6
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Djura! Approving so that the example works. We have another PR open to ensure that this is properly handled on the backend (I would like to handle both arrays and lists). I think we are converging on a solution there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a small mistake in the DCE tutorial. The flip angles in there are defined as a numpy array (which is very reasonable). However, the
_compute_t1_vfa_implfunction has been written with only lists in mind.The call
osipy.compute_t1_map(vfa_data, method="vfa")in the DCE-MRI analysis tutorial fails when the flip angles are defined as numpy arrays (see stacktrace below). Since the type hint states it should be a list anyways I thought it would be reasonable enough to only fix the documentation.Stacktrace