393 fillers ratio bug #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadronCollider
requested changes
Apr 24, 2025
app/criteria/utils.py
Outdated
| # добавлена предобработка слов - перевод в нижний регистр, очистка от пунктуации | ||
| audio_slide_words = [ | ||
| recognized_word.word.value for recognized_word in audio_slide.recognized_words] | ||
| recognized_word.word.value.strip().lower().translate(str.maketrans('', '', string.punctuation)) |
There was a problem hiding this comment.
чтобы не делать двойную работу (сначала убирать пробельные символы, потом пунктацию) - объедините их в maketrans
HadronCollider
force-pushed
the
393_FILLERS_RATIO_BUG
branch
from
d786c96 to
2af2d5e
Compare
HadronCollider
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлена предобработка слов в функции get_fillers модуля app/criteria/utils - очистка от пунктуации и перевод в нижний регистр