Clarify same-site CSRF risks with user-generated content #1949
+46
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasunsrivastav123-lang
requested review from
jmanico,
kwwall,
mackowski and
szh
as code owners
jmanico
reviewed
Jan 5, 2026
Member
jmanico
left a comment
jmanico
left a comment
There was a problem hiding this comment.
This is technically not CSRF but XSS. But I still discuss this issue. I noticed the formatting of your markdown is different then the rest of the doc. Can you make it more consistent?
Author
|
Thanks for the clarification — agreed that this scenario is technically XSS-enabled. I’ve updated the section to acknowledge that explicitly, kept it framed in the context of CSRF defense limitations, and adjusted the markdown structure and wording to be consistent with the rest of the document. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies same-site CSRF risks arising from user-generated content.
It explains scenarios where SameSite cookies alone are insufficient and
reinforces the need for CSRF tokens and proper request handling.