Conversation
ashish493
commented
Jun 12, 2020
ashish493
commented
- Added dataset
- Added models for predictions
- Added Notebooks for analysis
created analyzer app
ashish493
changed the title
|
@hardlyhuman Can u review the changes? |
|
Why do we have jupyter notebook files here? Also make necessary changes views.py of analyzer app |
|
Sure, I will make the changes for the analyzer app. |
ashish493
left a comment
ashish493
left a comment
There was a problem hiding this comment.
@hardlyhuman Can u review these few changes?
| def prediction(self): | ||
| try: | ||
| input_data = self.preprocessing(input_data) | ||
| prediction = self.predict(input_data) |
There was a problem hiding this comment.
And here, we will make changes once we decide a prpoer format of input data
There was a problem hiding this comment.
what's the point of having 'self.predict(input_data)'?
There was a problem hiding this comment.
Well, it doesn't have any significance at the moment as we haven't created the input serializers. So, I will remove and then create a separate app for prediction.
| from rest_framework.renderers import JSONRenderer | ||
|
|
||
| class EndpointSerializer(serializers.ModelSerializer): | ||
| read_only_fields = ("model_name", "param1", "param2", "param3") |
There was a problem hiding this comment.
I will modify it as soon as the necessary changes are made
2 participants
