fix: incorrect Error constructor syntax in files #2824
Conversation
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughUpdated error handling in two frontend files: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
frontend/src/app/api/auth/[...nextauth]/route.ts (1)
34-36: Error constructor syntax is now correct.Same fix and recommendations as the
checkIfProjectLeaderfunction above. Consider applying consistent error handling improvements to both functions.
🧹 Nitpick comments (1)
frontend/src/app/api/auth/[...nextauth]/route.ts (1)
20-22: Error constructor syntax is now correct.The fix properly consolidates the error message into a single string parameter. However, consider these improvements:
- Use error cause chaining (ES2022) to preserve the original error stack:
throw new Error('Failed to fetch project leader status', { cause: err })
- If
erris an Error object, extract its message:throw new Error(`Failed to fetch project leader status: ${err instanceof Error ? err.message : String(err)}`)
- Since this function is called during JWT callback (line 78) without visible error handling, consider whether re-throwing is appropriate or if the auth flow should degrade gracefully.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
frontend/src/app/api/auth/[...nextauth]/route.ts(2 hunks)frontend/src/components/ModuleForm.tsx(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-12T17:14:28.536Z
Learnt from: Rajgupta36
Repo: OWASP/Nest PR: 1717
File: frontend/src/app/mentorship/programs/[programKey]/edit/page.tsx:90-128
Timestamp: 2025-07-12T17:14:28.536Z
Learning: Both ProgramForm (programCard.tsx) and ModuleForm (mainmoduleCard.tsx) components already implement HTML validation using the `required` attribute on form fields. The browser's native validation prevents form submission and displays error messages when required fields are empty, eliminating the need for additional JavaScript validation before GraphQL mutations.
Applied to files:
frontend/src/components/ModuleForm.tsx
nileshpahari
force-pushed
the
fix/incorrect-error-constructor-usage-2803
branch
from
cf43342 to
7bcb563
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/src/components/ModuleForm.tsx (1)
286-290: Good: usesetErrorinstead of throwing; consider a better fallback for non-Error valuesSwitching from throwing to
setErrorfixes the unhandled rejection and correctly surfaces failures in the UI while still clearing results and hiding suggestions. One small improvement: for non-Errorvalues, the message currently ends with an empty suffix; you could preserve more context or at least show a generic fallback, e.g.:setError( `Error fetching suggestions: ${ err instanceof Error ? err.message : String(err || 'Unknown error') }` )
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
frontend/src/app/api/auth/[...nextauth]/route.ts(2 hunks)frontend/src/components/ModuleForm.tsx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- frontend/src/app/api/auth/[...nextauth]/route.ts
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: Rajgupta36
Repo: OWASP/Nest PR: 1717
File: frontend/src/app/mentorship/programs/[programKey]/edit/page.tsx:90-128
Timestamp: 2025-07-12T17:14:28.536Z
Learning: Both ProgramForm (programCard.tsx) and ModuleForm (mainmoduleCard.tsx) components already implement HTML validation using the `required` attribute on form fields. The browser's native validation prevents form submission and displays error messages when required fields are empty, eliminating the need for additional JavaScript validation before GraphQL mutations.
📚 Learning: 2025-07-12T17:14:28.536Z
Learnt from: Rajgupta36
Repo: OWASP/Nest PR: 1717
File: frontend/src/app/mentorship/programs/[programKey]/edit/page.tsx:90-128
Timestamp: 2025-07-12T17:14:28.536Z
Learning: Both ProgramForm (programCard.tsx) and ModuleForm (mainmoduleCard.tsx) components already implement HTML validation using the `required` attribute on form fields. The browser's native validation prevents form submission and displays error messages when required fields are empty, eliminating the need for additional JavaScript validation before GraphQL mutations.
Applied to files:
frontend/src/components/ModuleForm.tsx
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/src/components/ModuleForm.tsx (1)
289-295: Error handling is solid; consider simplifying nested ternary for readabilityThe new error handling correctly derives a user-facing message from different
errtypes and surfaces it viasetError, which is a good improvement over throwing. The nested ternary, though, is a bit hard to scan (and was flagged by Sonar); anif / else if / elsechain would be clearer.You could refactor like this:
- const errorMessage = - err instanceof Error - ? err.message - : typeof err === 'string' - ? err - : 'An unexpected error occurred' - setError(`Error fetching suggestions: ${errorMessage}`) + let errorMessage: string + + if (err instanceof Error) { + errorMessage = err.message + } else if (typeof err === 'string') { + errorMessage = err + } else { + errorMessage = 'An unexpected error occurred' + } + + setError(`Error fetching suggestions: ${errorMessage}`)
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/src/components/ModuleForm.tsx(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: Rajgupta36
Repo: OWASP/Nest PR: 1717
File: frontend/src/app/api/auth/[...nextauth]/route.ts:13-25
Timestamp: 2025-08-10T11:08:47.258Z
Learning: In the OWASP Nest codebase (frontend/src/app/api/auth/[...nextauth]/route.ts), input validation and string trimming for authentication-related queries like `isProjectLeader` and `isMentor` are handled in the backend rather than the frontend. The backend is responsible for sanitizing and validating input parameters.
Learnt from: Rajgupta36
Repo: OWASP/Nest PR: 1717
File: frontend/src/app/mentorship/programs/[programKey]/edit/page.tsx:90-128
Timestamp: 2025-07-12T17:14:28.536Z
Learning: Both ProgramForm (programCard.tsx) and ModuleForm (mainmoduleCard.tsx) components already implement HTML validation using the `required` attribute on form fields. The browser's native validation prevents form submission and displays error messages when required fields are empty, eliminating the need for additional JavaScript validation before GraphQL mutations.
📚 Learning: 2025-07-12T17:14:28.536Z
Learnt from: Rajgupta36
Repo: OWASP/Nest PR: 1717
File: frontend/src/app/mentorship/programs/[programKey]/edit/page.tsx:90-128
Timestamp: 2025-07-12T17:14:28.536Z
Learning: Both ProgramForm (programCard.tsx) and ModuleForm (mainmoduleCard.tsx) components already implement HTML validation using the `required` attribute on form fields. The browser's native validation prevents form submission and displays error messages when required fields are empty, eliminating the need for additional JavaScript validation before GraphQL mutations.
Applied to files:
frontend/src/components/ModuleForm.tsx
🪛 GitHub Check: SonarCloud Code Analysis
frontend/src/components/ModuleForm.tsx
[warning] 292-294: Extract this nested ternary operation into an independent statement.
nileshpahari
force-pushed
the
fix/incorrect-error-constructor-usage-2803
branch
from
1fade10 to
bed93a6
Compare
arkid15r
left a comment
arkid15r
left a comment
There was a problem hiding this comment.
I don't think you did.
github-actions
bot
added
docs
nileshpahari
force-pushed
the
fix/incorrect-error-constructor-usage-2803
branch
from
addedb9 to
78ff559
Compare
github-actions
bot
removed
docs
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/src/app/api/auth/[...nextauth]/route.ts (1)
20-36: Error construction now correct; optional refinement to include cleaner message.The new
throw new Error(\Failed to fetch ... status Error: ${err}`)calls in both helpers fix the original bug:Error` is now constructed with a single message string that includes the underlying error, so it’s no longer silently discarded.If you want slightly clearer messages (and to avoid cases like
Error: [object Object]), you could optionally tighten this to:throw new Error( `Failed to fetch project leader status: ${ err instanceof Error ? err.message : String(err) }` )and similarly for the mentor status path. Not required for correctness, but a bit more robust.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
frontend/src/app/api/auth/[...nextauth]/route.ts(2 hunks)frontend/src/components/ModuleForm.tsx(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: Rajgupta36
Repo: OWASP/Nest PR: 1717
File: frontend/src/app/api/auth/[...nextauth]/route.ts:13-25
Timestamp: 2025-08-10T11:08:47.258Z
Learning: In the OWASP Nest codebase (frontend/src/app/api/auth/[...nextauth]/route.ts), input validation and string trimming for authentication-related queries like `isProjectLeader` and `isMentor` are handled in the backend rather than the frontend. The backend is responsible for sanitizing and validating input parameters.
📚 Learning: 2025-08-10T11:08:47.258Z
Learnt from: Rajgupta36
Repo: OWASP/Nest PR: 1717
File: frontend/src/app/api/auth/[...nextauth]/route.ts:13-25
Timestamp: 2025-08-10T11:08:47.258Z
Learning: In the OWASP Nest codebase (frontend/src/app/api/auth/[...nextauth]/route.ts), input validation and string trimming for authentication-related queries like `isProjectLeader` and `isMentor` are handled in the backend rather than the frontend. The backend is responsible for sanitizing and validating input parameters.
Applied to files:
frontend/src/app/api/auth/[...nextauth]/route.ts
📚 Learning: 2025-07-12T17:14:28.536Z
Learnt from: Rajgupta36
Repo: OWASP/Nest PR: 1717
File: frontend/src/app/mentorship/programs/[programKey]/edit/page.tsx:90-128
Timestamp: 2025-07-12T17:14:28.536Z
Learning: Both ProgramForm (programCard.tsx) and ModuleForm (mainmoduleCard.tsx) components already implement HTML validation using the `required` attribute on form fields. The browser's native validation prevents form submission and displays error messages when required fields are empty, eliminating the need for additional JavaScript validation before GraphQL mutations.
Applied to files:
frontend/src/components/ModuleForm.tsx
🔇 Additional comments (1)
frontend/src/components/ModuleForm.tsx (1)
286-291: Good fix: surface fetch errors via state instead of throwing.Using
setErrorin thecatchblock (while still clearing results and hiding suggestions) correctly avoids the previous unhandled promise rejection fromuseEffectand routes failures into the existing UI error message. This matches the PR objective without changing success-path behavior.
|
Sorry about that, @arkid15r . While addressing CodeRabbit’s suggestions, I copy-pasted them quickly and didn’t run the checks afterward. I’ve fixed the issue now, and it won’t happen again. Please take a look when you can |
|
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
frontend/src/app/api/auth/[...nextauth]/route.ts (1)
37-39: Same error-handling pattern as above — looks goodThis catch block mirrors the updated pattern in
checkIfProjectLeader, so the bug is consistently fixed here as well. No additional changes needed beyond any optional refactor you decide to apply to both.
🧹 Nitpick comments (1)
frontend/src/app/api/auth/[...nextauth]/route.ts (1)
21-23: Error construction fix is correct; optional small reuse/refactorUsing a single-string
Errormessage and explicitly embeddingerr.message(with a sane fallback) correctly fixes the original bug and keeps the thrown error informative. This is good as-is.If you want to DRY things up later, you could extract a tiny helper like
toStatusError(context: string, err: unknown)and reuse it in bothcheckIfProjectLeaderandcheckIfMentor, but that’s strictly optional. Based on learnings, no additional input validation is needed here because it’s handled on the backend.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/src/app/api/auth/[...nextauth]/route.ts(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: Rajgupta36
Repo: OWASP/Nest PR: 1717
File: frontend/src/app/api/auth/[...nextauth]/route.ts:13-25
Timestamp: 2025-08-10T11:08:47.258Z
Learning: In the OWASP Nest codebase (frontend/src/app/api/auth/[...nextauth]/route.ts), input validation and string trimming for authentication-related queries like `isProjectLeader` and `isMentor` are handled in the backend rather than the frontend. The backend is responsible for sanitizing and validating input parameters.
📚 Learning: 2025-08-10T11:08:47.258Z
Learnt from: Rajgupta36
Repo: OWASP/Nest PR: 1717
File: frontend/src/app/api/auth/[...nextauth]/route.ts:13-25
Timestamp: 2025-08-10T11:08:47.258Z
Learning: In the OWASP Nest codebase (frontend/src/app/api/auth/[...nextauth]/route.ts), input validation and string trimming for authentication-related queries like `isProjectLeader` and `isMentor` are handled in the backend rather than the frontend. The backend is responsible for sanitizing and validating input parameters.
Applied to files:
frontend/src/app/api/auth/[...nextauth]/route.ts
2 participants
Proposed change
Correct the syntax of the
Errorconstructor, in order to preserve the original error.Files modified
frontend/src/app/api/auth/[...nextauth]/route.tsfrontend/src/components/ModuleForm.tsxResolves #2803
Checklist
make check-testlocally; all checks and tests passed.