Implemented unit tests for HTTP client with 79% coverage #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Added comprehensive test suite for the HTTP client in Nettacker's core library.
These tests ensure proper functionality for HTTP requests, error handling, session management, response parsing, and condition matching logic.
Type of change
Code refactoring without any functionality changes
Adding Test Modules without any functionality changes
Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locallyThis test coverage helps ensure the HTTP client remains reliable during future development and refactoring.