Skip to content

Fix: Python 3.12 SSL compatibility - replace ssl.wrap_socket #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deekshithaby wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix: Python 3.12 SSL compatibility - replace ssl.wrap_socket #1177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d47186
Fix: Update SSL tests and socket functions for Python 3.12 compatibility
deekshithaby Dec 10, 2025
1cbd140
Fix: Disable SSL certificate verification in SSLContext
deekshithaby Dec 11, 2025
5ade02b
Fix: Remove trailing whitespace in test_ssl.py
deekshithaby Dec 14, 2025
b8f7cce
Merge branch 'master' into fix/python-3.12-ssl-compatibility
deekshithaby Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion nettacker/core/lib/socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@ def create_tcp_socket(host, port, timeout):
return None

try:
socket_connection = ssl.wrap_socket(socket_connection)
context = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT)
context.check_hostname = False
context.verify_mode = ssl.CERT_NONE
socket_connection = context.wrap_socket(socket_connection, server_hostname=host)
ssl_flag = True
except Exception:
socket_connection = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
Expand Down
5 changes: 4 additions & 1 deletion nettacker/core/lib/ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,10 @@ def create_tcp_socket(host, port, timeout):
return None

try:
socket_connection = ssl.wrap_socket(socket_connection)
context = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT)
context.check_hostname = False
context.verify_mode = ssl.CERT_NONE
socket_connection = context.wrap_socket(socket_connection, server_hostname=host)
ssl_flag = True
except Exception:
socket_connection = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
Expand Down
4 changes: 2 additions & 2 deletions tests/core/lib/test_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def responses():

class TestSocketMethod:
@patch("socket.socket")
@patch("ssl.wrap_socket")
@patch("ssl.SSLContext.wrap_socket")
def test_create_tcp_socket(self, mock_wrap, mock_socket):
HOST = "example.com"
PORT = 80
Expand All @@ -151,7 +151,7 @@ def test_create_tcp_socket(self, mock_wrap, mock_socket):
socket_instance = mock_socket.return_value
socket_instance.settimeout.assert_called_with(TIMEOUT)
socket_instance.connect.assert_called_with((HOST, PORT))
mock_wrap.assert_called_with(socket_instance)
mock_wrap.assert_called_with(socket_instance, server_hostname=HOST)

def test_response_conditions_matched_socket_icmp(self, socket_engine, substeps, responses):
result = socket_engine.response_conditions_matched(
Expand Down
5 changes: 3 additions & 2 deletions tests/core/lib/test_ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def connection_params():

class TestSslMethod:
@patch("socket.socket")
@patch("ssl.wrap_socket")
@patch("ssl.SSLContext.wrap_socket")
def test_create_tcp_socket(self, mock_wrap, mock_socket, connection_params):
create_tcp_socket(
connection_params["HOST"], connection_params["PORT"], connection_params["TIMEOUT"]
Expand All @@ -190,7 +190,8 @@ def test_create_tcp_socket(self, mock_wrap, mock_socket, connection_params):
socket_instance.connect.assert_called_with(
(connection_params["HOST"], connection_params["PORT"])
)
mock_wrap.assert_called_with(socket_instance)

mock_wrap.assert_called_with(socket_instance, server_hostname=connection_params["HOST"])

@patch("nettacker.core.lib.ssl.is_weak_cipher_suite")
@patch("nettacker.core.lib.ssl.is_weak_ssl_version")
Expand Down