fix: correct expected tags value in test_dbNodeFromNode#883
Open
shiwani42 wants to merge 1 commit intoOWASP:mainfrom
Open
fix: correct expected tags value in test_dbNodeFromNode#883shiwani42 wants to merge 1 commit intoOWASP:mainfrom
shiwani42 wants to merge 1 commit intoOWASP:mainfrom
Conversation
The test expected tags="1,2" but dbNodeFromCode joins the input list ["111-111", "222-222"] with commas, producing "111-111,222-222". The expected value in the test was wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #870
Summary
test_dbNodeFromNodeinapplication/tests/db_test.py(line 1083) expectedtags="1,2"butdbNodeFromCodejoins the input list["111-111", "222-222"]with commas, producing"111-111,222-222". The expected value in the test was stale after the tag fix in #822 and was never updated.Changes
tagsvalue from"1,2"to"111-111,222-222"intest_dbNodeFromNodeTest plan
test_dbNodeFromNodepassesdb_test.pysuite run -- no regressions introduced by this changeblackformatting verified