Skip to content

Conversation

@gerardocanedoUCU
Copy link
Contributor

@gerardocanedoUCU gerardocanedoUCU commented Dec 16, 2025

Summary:
Implementation between OWASP Cornucopia (CC) and Threat Dragon.

Description for the changelog:
Added a new type of diagram EoP integrated with deck of CC cards.
Supports English, Spanish, Russian and French. If CC where to add more languages, they can easily be added to this implementation.

Declaration:

  • appropriate unit tests have been created / modified
  • functional tests created / modified for changes in functionality
  • any use of AI has been declared in this pull request

Other info:

This Feature is the product of a Coding Challenge of the Universidad Católica del Uruguay (UCU). Thanks to all the students who have contributed!

Closes #1373

javiermorenov1203 and others added 30 commits December 10, 2025 14:21
when creating a model, the EoP diagram has been added in the select when
adding a diagram. The thumbail after adding still needs to be modified.
Added eop.js model that allows to retrieve the specific eop threats
Se agrega el Script generate-cornucopia que descarga el json de la api en el build de la aplicacion.
Tambien se agrega en el packge.json para ejecutar este script cuando se hace el build.
add generate-cornucopia prebuild script
Tests were modified since there are more categories in total now
@sydseter
Copy link

sydseter commented Dec 18, 2025

@gerardocanedoUCU Thank you so much for your work. We really appreciate all the effort you are putting in.

The image combined with the text is, as you probably know, slightly misleading. I have a logo here that you can use instead of the cornucopia logo.

The svg might be preferable to use, but I have provided the png as well. Regarding the text for the diagram. Would it be possible to have it be: "EoP Games"?

I understand EoP is shorter, but this way, it may become more clear that there will be more than one and that EoP, eventually, will be among he options.

eop

eop

@gerardocanedoUCU
Copy link
Contributor Author

gerardocanedoUCU commented Dec 18, 2025 via email

@gerardocanedoUCU
Copy link
Contributor Author

Can you please approve the fixes for e2e testing? Also. we have changed the image, changed the titles and removed the script header

@gerardocanedoUCU
Copy link
Contributor Author

can you approve the test changes ?

@sydseter
Copy link

@gerardocanedoUCU Just had a look at the solution. Fantastic!
I have one question regarding extendability. Are we making it easy to add more games within the diagram?
E.g: what happens if we add the Moible app edition https://cornucopia.owasp.org/api/cre/mobileapp/en?
Could that become problematic, or would adding it only mean that you need to add a new select box and ensure the right categories and card codes are populated into the form?

@javiermorenov1203
Copy link
Collaborator

@sydseter Thank you for the feedback. As you mentioned, the initial idea was to have a dropdown which would allow to select the EoP game when creating a threat and populate the categories and numbers with the corresponding information depending on the selected game. However, due to time limitations, we decided to focus mainly on cornucopia for this first version.

We have a preliminary version which is more extendable and includes the dropdown in our repository. In case we are able to finish it, we will be adding it to this PR.

@sydseter
Copy link

@sydseter Thank you for the feedback. As you mentioned, the initial idea was to have a dropdown which would allow to select the EoP game when creating a threat and populate the categories and numbers with the corresponding information depending on the selected game. However, due to time limitations, we decided to focus mainly on cornucopia for this first version.

We have a preliminary version which is more extendable and includes the dropdown in our repository. In case we are able to finish it, we will be adding it to this PR.

That is fine, I would, however make sure to no use cornucopia-en.json as file name. Just changing the name to cornucopia-webapp-en.json would be a great improvement.

@jgadsden jgadsden added enhancement New feature or request theat engine labels Dec 19, 2025
Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be final work to do with the docker build action in the github workflows
This cna be split out as a separate issue if you wish to go ahead and merge anyway @gerardocanedoUCU ?

@jgadsden jgadsden merged commit 0ecdb29 into OWASP:main Dec 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request theat engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration between Cornucopia and Threat Dragon