Skip to content

Conversation

@eratio08
Copy link
Collaborator

@eratio08 eratio08 commented Dec 18, 2025

Summary:

Resolves #1417

Currently it's not possible to perform any api action on protected branches using the Github integration. The branch name is not determined correctly as the logic assumes the branch to be a simple string when it's actually an object.

Description for the changelog:

Check if the branch parameter is an object to access the value field for the branch name, otherwise use the parameter as the branch name.

Declaration:

  • appropriate unit tests have been created / modified
  • functional tests created / modified for changes in functionality (Not sure if this applies, due to the github scope)
  • any use of AI has been declared in this pull request

Other info:

@jgadsden
Copy link
Collaborator

jgadsden commented Dec 18, 2025

Hello @eratio08 , could you raise an issue for this please?
(do not worry about the link checker error, that is only transient)

@jgadsden jgadsden added bug Something isn't working priority labels Dec 19, 2025
@eratio08 eratio08 marked this pull request as ready for review December 19, 2025 09:27
Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this contribution @eratio08 , and extra kudos for adding unit tests - much appreciated

@jgadsden jgadsden merged commit f57779e into OWASP:main Dec 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Branch name is detected as [object Object] for protected branches in the Github integration

2 participants