Extendable EoP games diagram #1418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactore eop diagram so that more eop games can be added to the existintg diagram
javiermorenov1203
requested review from
jgadsden and
lreading
as code owners
javiermorenov1203
requested review from
jgadsden
and removed request for
jgadsden
jgadsden
approved these changes
Dec 23, 2025
Collaborator
jgadsden
left a comment
jgadsden
left a comment
There was a problem hiding this comment.
Hello @javiermorenov1203 , many thanks for these updates and certainly this is good to have
just one small point from my point of view, could the 'EoP Games' frop down be populated by the first item in the list by default? In this case 'OWASP Cornucopia'
Collaborator
Author
|
@jgadsden the corresponding modification has been made |
Collaborator
Thst is perfect @javiermorenov1203 , thank you and going ahead with the merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a version of EoP games diagram which we believe is more extendable.
@jgadsden @sydseter I create this PR in case you prefer to have this version.
Description for the changelog:
A game selector has been added to ThreatEditDialog when the type of the diagram is EoP.
The games are added in td.vue\src\service\threats\models\eop\index.js
Whenever a new game is added, a new file should be created in this directory.
For now, the file should have the same methods as cornucopia.js since these are used in ThreatEditDialog.