Skip to content

Conversation

@sn3ha-dev278
Copy link
Collaborator

@sn3ha-dev278 sn3ha-dev278 commented Jan 1, 2026

Summary:

Fixes an issue where selected diagram elements were included in exported SVG and PNG files.
Closes #1318.

Description for the changelog:

Remove selection highlights from exported SVG and PNG diagrams.

Declaration:

Thanks for submitting a pull request, please make sure:

  • content meets the license for this project
  • appropriate unit tests have been created / modified
  • functional tests created / modified for changes in functionality
  • you have read the contribution guide and agree to the Code of Conduct
  • any use of AI has been declared in this pull request

Other info:

@jgadsden jgadsden added the enhancement New feature or request label Jan 1, 2026
Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sn3ha-dev278 , thanks for submitting the pull request
please answer the following:

  • appropriate unit tests have been created / modified
  • functional tests created / modified for changes in functionality if required
  • any use of AI

@jgadsden
Copy link
Collaborator

jgadsden commented Jan 7, 2026

tested with and without time-out delays, both work OK and no race condition detected
@sn3ha-dev278 this is an identical solution to one that used AI to provide the solution, can you confirm whether you used generative AI or not?

@sn3ha-dev278
Copy link
Collaborator Author

Thanks for the review.
1)Unit tests: I didn’t add new unit tests since this change only affects client-side export rendering and doesn’t touch core logic or data models.
2)Functional tests: No automated functional tests were added. I verified the fix manually by exporting PNG and SVG diagrams with selected elements and confirming that selection highlights no longer appear in the exports.
3)Use of AI: Generative AI was used for general guidance. However, I reviewed, understood, and manually tested before submitting.

Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for the testing and clarification @sn3ha-dev278

@jgadsden jgadsden merged commit 8cfbe01 into OWASP:main Jan 7, 2026
13 checks passed
@sn3ha-dev278 sn3ha-dev278 deleted the fix-export-selection branch January 8, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When exporting a diagram to a graphics format the selected items are shown selected in the exported image

2 participants