Fix Add the OWASP Cornucopia MobileApp Deck to OWASP Threat Dragon EoP Games diagram (#1447)#1459
Open
Mahaboobunnisa123 wants to merge 1 commit intoOWASP:mainfrom
Open
Conversation
Mahaboobunnisa123
requested review from
jgadsden and
lreading
as code owners
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #1447
This pull request adds support for the OWASP Cornucopia MobileApp deck to the existing EoP Games threat workflow. A new entry “OWASP Cornucopia Mobileapp” is added to the EoP Games dropdown in the threat dialog, implemented in the same way as the existing WebsiteApp edition.
Description for the changelog:
Add OWASP Cornucopia MobileApp deck support to EoP Games threats.
Declaration:
I have read the contribution guidelines and agree to follow them.
I have tested these changes locally.
This change follows the existing implementation pattern used for EoP Games decks.
Implementation details:
Added new MobileApp deck model:
td.vue/src/service/threats/models/eop/cornucopia-mobileapp.jsUpdated deck generation logic:
td.vue/src/plugins/generate-cornucopia.jsRegistered new deck in EoP index:
td.vue/src/service/threats/models/eop/index.jsUpdated lockfile:
td.vue/package-lock.jsonVerification:
Created a new EoP diagram locally and opened threat dialog. Verified the EoP Games dropdown now contains 'OWASP Cornucopia' and 'OWASP Cornucopia Mobileapp'.