core/app: fork-aware slot fraction timings - #4676
Open
KaloyanTanev wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
the
branch-invalid
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gloas #4676 +/- ##
========================================
Coverage ? 58.81%
========================================
Files ? 246
Lines ? 34896
Branches ? 0
========================================
Hits ? 20525
Misses ? 11811
Partials ? 2560 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the remaining thirds-based intra-slot timings fork-aware for the gloas quarter-slot schedule: the proposer/randao duty deadline now follows the attestation due offset (4s pre-gloas, 3s post) via
newSlotOffsetFunc, and the SSE block/block-gossip lateness thresholds resolve the same offset per slot instead of a hardcodedslotDuration/3. Also refitsse_head_delayhistogram buckets with quarter-slot boundaries (3s/9s, keeping 4s so existing dashboard queries are unaffected) and reword the thirds-era metric help texts.category: feature
ticket: #4324