Add 5 icons: figma, framer, npm, obra, sprout - #102
Open
Wolfr wants to merge 1 commit into
Open
Conversation
Brings over the 5 icons that were added on the unmerged 1.24.0 branch (commit a0d155c) but never landed on main. The 4 brand icons are filled artwork, so they follow the Brand…Fill convention: BrandFigmaFill, BrandFramerFill, BrandNpmFill, BrandObraFill. On the 1.24.0 branch figma/npm/obra lacked the -fill suffix, which made the generator emit them as StrokeIconProps with a spurious strokeWidth prop; the rename fixes both the naming and the prop type. Sprout is a stroked, non-brand icon and keeps its plain name. Generated react/svelte/vue components from the SVG sources and added the exports to each barrel; bumped the website icon count and search keywords. Verified the react package builds clean (publint OK). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying obra-icons with
|
| Latest commit: |
96f9a69
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://659d6f54.obra-icons.pages.dev |
| Branch Preview URL: | https://add-figma-framer-npm-obra-sp.obra-icons.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings over the 5 icons that were added on the unmerged
1.24.0branch (commita0d155c9) but never landed onmain: figma, framer, npm, obra, sprout.Rather than merge the whole
1.24.0branch (which also rewrote hundreds of unrelated icons), I extracted just the 5 new icons and ran them back through the real SVG-source → generator pipeline.Naming — applied the
FillconventionThe 4 brand icons are filled artwork, so they follow the
Brand…Fillconvention. On1.24.0, figma/npm/obra lacked the-fillsuffix, which made the generator emit them asStrokeIconPropswith a spuriousstrokeWidthprop. The rename fixes both the naming and the prop type.1.24.0nameBrandFigmaBrandFigmaFillFillIconPropsBrandFramerFillBrandFramerFillBrandNpmBrandNpmFillBrandObraBrandObraFillSproutSproutChanges
website/src/lib/svgs/.tsx/ svelte / vue), exported from each barrel at the correct alphabetical positioncount.ts1047 → 1052keywords.tssearch entries for all 5 iconsVerification
unbuild+publint: All good!); new icons present indistBrandFigmaFill→FillIconProps/fill={color};Sprout→StrokeIconProps-fill(the layers areoi-brand-figma, etc. — that's where the names originate). A futureimport:iconsrun from Figma will reintroduce the non-fill names and diverge from this PR. The Figma layers should be renamed tooi-brand-figma-fill/oi-brand-npm-fill/oi-brand-obra-fillto make this stick.import_extis''but the committed barrels use.mjs. I matched the committed.mjsstyle by hand rather than let the generator rewrite all 1047 import lines. The generator'simport_extshould be set to'mjs'(or the barrels regenerated) separately so the two stay in sync.🤖 Generated with Claude Code