Skip to content

CSS Update #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

CSS Update #421

wants to merge 9 commits into from

Conversation

yoLewshi
Copy link
Collaborator

@yoLewshi yoLewshi commented Feb 11, 2025

An attempt to improve styling without majorly changing the markup. Won't be offended if you don't like it, equally happy to really tear into things if you want to radically change the UI in some way.

You can play around with the colours used for the variables to try out alternatives if you like.

  • Mostly added a lot of css variables which can be tweaked to change the styling
  • Altered the colours (less grey, more blue)
  • Moved cruise definition and user login elements to make use of the space at the top of the page
  • Removed some hardcoded inline styles and replaced with classes

image

image

@yoLewshi yoLewshi marked this pull request as ready for review February 11, 2025 22:53
@davidpablocohn
Copy link
Collaborator

I really like the idea of moving the login and current/load file elements up to the top, as well as color coding the logged messages on the main console page. Not as wild about the blue vs gray change.

Also: not able to get it to run properly on the test server at http://143.110.155.117/ - I pulled the patch locally, but it's looking like maybe some path or permission needs tweaking:

Screenshot 2025-02-18 at 11 53 08 AM

@yoLewshi
Copy link
Collaborator Author

yoLewshi commented Mar 2, 2025

I've swapped the blue back to grey:

image

Also changed how it references the css file but I can't get the standard install running locally and I'm about to go to sea so don't want to mess too much with mine. Did you get any sort of browser console error when it failed to load?

@davidpablocohn
Copy link
Collaborator

Thanks! No browser console errors, and yet much of the styling is as borked as before. Very puzzling...

Regardless, no worries - let's put this on hold until you're back. Until then, fair winds and following seas!

@davidpablocohn
Copy link
Collaborator

Hi Lewis - checking in: are you back shoreside? I've been pushing a whole bunch of changes (most importantly the Ella-templating) into dev, and would love to push it all to master soon (maybe as v2.0.0?). It would be great to include these style fixes if you've got a minute to look at whatever's going wrong for me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants