Fix ocaml-compiler.5.3.0~rc1 package #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Octachron
merged commit da00385
into
Octachron:OCaml_5.3.0_release_candidate
1 check failed
Owner
|
Thanks for the fix ! |
Owner
|
There was a mixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem before is that we had a formula something like
("host-system-mingw" & "bar_a" {os = "win32"} | "host-system-msvc" & "bar_b" {os = "win32"} | "host-system-other" {os != "win32"}). In removinghost-system-other, this left the problem that the entire formula couldn't be satisfied on non-Windows systems. It's not possible to put{os = "win32"}on all the packages in the remaining formula because the package will fail opam lint.The simplest solution is that put here - we just repeat the base-unix dependency.