Update Calamari.AzureWebApp to support .NET 6.0 (#1355) #1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add NET 6.0 support and start rewriting stuff * Continued refactoring AzureWebApp to support .Net Core * Use msdeploy.exe to do Azure WebApp deployments * Delete output file at end of deployment * Fix issue with physicalpath and create output file in temp folder * NetFx uses original code, but NetCore uses MsDeploy.exe * Update build process and tests * Update code to locate msdeploy executable * Add exception if msdeploy.exe is not found * Only support running on Windows * Change tests to use modern SDK as well * Add retry to assertion * Use cancellation token * Fix poison merge * Create new app service for each test * Bundle Web Deploy V3 installer * Add new Calamar.AzureWebApp.DotNetCoreShim application * Complete and use new NetCoreShim project * Don't include netcoreshim in full framework build * Fix shim not extracting for published tests * Fix app offline message appearing erroneously * Update shim * Remove dependency on `Calamari.Common`. Later step will extract this class into its own * Minor cleanup and update packaged shim --------- Co-authored-by: Robert E <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of 7b72732 - which should now work given we're packaging calamari differently!
Add NET 6.0 support and start rewriting stuff
Continued refactoring AzureWebApp to support .Net Core
Use msdeploy.exe to do Azure WebApp deployments
Delete output file at end of deployment
Fix issue with physicalpath and create output file in temp folder
NetFx uses original code, but NetCore uses MsDeploy.exe
Update build process and tests
Update code to locate msdeploy executable
Add exception if msdeploy.exe is not found
Only support running on Windows
Change tests to use modern SDK as well
Add retry to assertion
Use cancellation token
Fix poison merge
Create new app service for each test
Bundle Web Deploy V3 installer
Add new Calamar.AzureWebApp.DotNetCoreShim application
Complete and use new NetCoreShim project
Don't include netcoreshim in full framework build
Fix shim not extracting for published tests
Fix app offline message appearing erroneously
Update shim
Remove dependency on
Calamari.Common. Later step will extract this class into its ownMinor cleanup and update packaged shim