Fix some warnings/nullable inconsistencies. #1451
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt can be passed a null value
…ing annotations, plus 'fixes' from that.
MissedTheMark
changed the title
rain-on
reviewed
Mar 12, 2025
| @@ -10,6 +10,7 @@ namespace Calamari.Common.Features.Deployment.Journal | |||
| { | |||
| public class DeployedPackage | |||
| { | |||
| #pragma warning disable CS8618 // Non-nullable field must contain a non-null value when exiting constructor - Handled by guard method. | |||
There was a problem hiding this comment.
I'm confused - the API allows null - but then we bounce it via the Guard?
There was a problem hiding this comment.
I think it's because when using the XElement constructor, the PackageId or PackageVersion might come out as null, and this gives you a 'nice' message?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Calamari has a whole bunch of build warnings, and nullable things that are inconsistent/misleading.
The PR endeavors to fix some of these problems.
How to review
For once, my commits are well named, and each contains a specific change across files, or changes in a single file. It would probably be best to go through each commit one at a time, using the commit message for context, rather than attempting to review the whole PR without context.