Skip to content

Introduce "Green-means-go" Renovate PR Messages #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2025

Conversation

samdanaei
Copy link
Contributor

@samdanaei samdanaei commented Apr 4, 2025

Background

We are establishing a structured dependency update process for both the Tentacle and Halibut repositories. As part of this initiative, we will introduce a "Green-means-go" PR message, similar to the dependency update procedures used in Octopus Server. This will allow developers to approve certain dependencies with minimal scrutiny, while ensuring that other dependencies receive the appropriate level of review.

Results

When a Renovate PR is created, the PR message will inform the developer if it is relatively safe to merge. This applies only to packages with good test coverage, ensuring any issues are easily detected during TeamCity builds.

The process enables developers to add new "Green-means-go" rules. For example:

{
  matchPackageNames: ['Nsubstitute'],
  prBodyNotes: [
    ...preCannedPrNotes.greenMeansGo,
    'Used extensively throughout tests.',
  ],
}

Relevant Tentacle PR

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@samdanaei samdanaei changed the title Include PR Comments with some common packages Establish Dependency Update Process with "Green-means-go" PR Messages Apr 4, 2025
@samdanaei samdanaei changed the title Establish Dependency Update Process with "Green-means-go" PR Messages Introduce "Green-means-go" Renovate PR Messages Apr 4, 2025
@samdanaei samdanaei marked this pull request as ready for review April 7, 2025 00:12
@samdanaei samdanaei requested a review from a team as a code owner April 7, 2025 00:12
@samdanaei samdanaei merged commit 557eff0 into main Apr 7, 2025
17 checks passed
@samdanaei samdanaei deleted the sast/si/introduce-renovate-pr-comments branch April 7, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants