Open
Conversation
liamhughes
changed the base branch from
main
to
liamhughes/devex-136-use-new-evaluations-endpoint
Base automatically changed from
liamhughes/devex-136-use-new-evaluations-endpoint
to
main
April 1, 2026 05:15
liamhughes
force-pushed
the
liamhughes/devex-82-add-fractional-evaluation-support-to-java-client-library
branch
from
1cd8040 to
4f02169
Compare
liamhughes
force-pushed
the
liamhughes/devex-82-add-fractional-evaluation-support-to-java-client-library
branch
from
4f02169 to
a53abd3
Compare
liamhughes
commented
Apr 2, 2026
| @@ -26,10 +28,10 @@ byte[] getContentHash() { | |||
| } | |||
|
|
|||
| ProviderEvaluation<Boolean> evaluate(String slug, Boolean defaultValue, EvaluationContext evaluationContext) { | |||
Contributor
Author
There was a problem hiding this comment.
This method mostly matches the .NET equivalent logically, though with a different shape. I propose that we align them further prior to the next piece of work in this area.
liamhughes
commented
Apr 2, 2026
| if (rolloutPercentage < 100) { | ||
| return ProviderEvaluation.<Boolean>builder() | ||
| .value(false) | ||
| .reason(Reason.TARGETING_MATCH.toString()) |
Contributor
Author
There was a problem hiding this comment.
liamhughes
commented
Apr 2, 2026
Contributor
Author
There was a problem hiding this comment.
liamhughes
changed the title
liamhughes
commented
Apr 2, 2026
| return null; | ||
| } | ||
| List<FeatureToggleEvaluation> evaluations = OctopusObjectMapper.INSTANCE.readValue(httpResponse.body(), new TypeReference<>(){}); | ||
| var evaluations = OctopusObjectMapper.INSTANCE.readValue(httpResponse.body(), new TypeReference<List<FeatureToggleEvaluation>>(){}); |
Contributor
Author
There was a problem hiding this comment.
I lied in my last PR. Well, not that I lied, but I did think we were on Java 8 rather than 11.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds client-side fractional (percentage) rollout evaluation to the Java OpenFeature provider, aligning behavior with the .NET provider and re-enabling the spec fixture suite.
Changes:
- Introduced MurmurHash3-based bucketing (evaluationKey + targetingKey) to support percentage rollouts.
- Updated evaluation flow in
OctopusContextto incorporate rollout checks before segment matching. - Reworked/expanded tests (including re-enabling spec fixture tests) to validate cross-SDK-consistent bucketing and evaluation behavior.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/main/java/com/octopus/openfeature/provider/OctopusContext.java |
Implements normalized bucketing via MurmurHash3 and integrates rollout gating into flag evaluation flow. |
src/test/java/com/octopus/openfeature/provider/OctopusContextTests.java |
Replaces prior tests with extensive rollout + segment evaluation cases and cross-SDK bucketing vectors. |
src/test/java/com/octopus/openfeature/provider/SpecificationTests.java |
Re-enables parameterized specification fixture tests. |
src/test/java/com/octopus/openfeature/provider/FeatureToggleEvaluationDeserializationTests.java |
Tightens TypeReference typing for toggle list deserialization. |
src/main/java/com/octopus/openfeature/provider/OctopusClient.java |
Tightens TypeReference typing when deserializing toggle evaluations. |
pom.xml |
Adds Apache Commons Codec dependency for MurmurHash3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
We are implementing client-side percentage rollout evaluation to our three OpenFeature provider libraries.
The .NET provider had this added in OctopusDeploy/openfeature-provider-dotnet#45.
This PR adds this to the Java library.
Resolves https://linear.app/octopus/issue/DEVEX-82/add-fractional-evaluation-support-to-java-client-library
Changes
OctopusContextto have the same logical flow as the .NET equivalent, including implementinggetNormalizeNumberto hash theevaluationKey+targetingKeyfor percentage rollout.OctopusContextTestsreplace existing tests and these now align with the .NET equivalents to ensure consistent evaluation.Notes for review
Reasonoptions chosen. It may be good to talk these through. Or perhaps ignore them until we do reasons properly and across our feature toggles ecosystem.