Skip to content

feat: skip tickets with Status="Expired" #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
Merged

feat: skip tickets with Status="Expired" #61

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b34af8b
include parent tx and deposit in Slack alerts
mahsamoosavi Jun 20, 2025
4fe9fd5
skip expired retryables based on Notion status
mahsamoosavi Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions packages/retryable-monitor/handlers/notion/alertUntriagedRetraybles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ const formatDate = (iso: string | undefined) => {
hour12: false,
timeZone: 'UTC',
timeZoneName: 'short',
}).format(date) // e.g. "Jun 6, 2025, 04:51 UTC"
}).format(date)
}

const isNearExpiry = (iso: string | undefined, hours = 24) => {
if (!iso) return false
const expiry = new Date(iso).getTime()
const now = Date.now()
const timeLeftMs = expiry - now
return timeLeftMs <= hours * 60 * 60 * 1000
return timeLeftMs > 0 && timeLeftMs <= hours * 60 * 60 * 1000
}

export const alertUntriagedNotionRetryables = async () => {
Expand All @@ -46,28 +46,33 @@ export const alertUntriagedNotionRetryables = async () => {

for (const page of response.results) {
const props = (page as any).properties
const status = props?.Status?.select?.name || '(unknown)'
if (status === 'Expired') continue

const timeoutRaw = props?.timeoutTimestamp?.date?.start
const timeoutStr = formatDate(timeoutRaw)
const retryableUrl = props?.ChildTx?.title?.[0]?.text?.content || '(unknown)'
const parentTx = props?.ParentTx?.rich_text?.[0]?.text?.content || '(unknown)'
const deposit = props?.TotalRetryableDeposit?.rich_text?.[0]?.text?.content || '(unknown)'
const decision = props?.Decision?.select?.name || '(unknown)'

const expiryTime = timeoutRaw ? new Date(timeoutRaw).getTime() : Infinity
const now = Date.now()
const expiryTime = timeoutRaw ? new Date(timeoutRaw).getTime() : Infinity
const hoursLeft = (expiryTime - now) / (1000 * 60 * 60)

let message = ''

if (decision === 'Triage') {
if (hoursLeft <= 72) {
message = `🚨🚨 Retryable ticket needs **IMMEDIATE** triage (expires soon!):\n• Retryable: ${retryableUrl}\n• Timeout: ${timeoutStr}\n→ Please triage urgently.`
message = `🚨🚨 Retryable ticket needs IMMEDIATE triage (expires soon!):\n• Retryable: ${retryableUrl}\n• Timeout: ${timeoutStr}\n• Parent Tx: ${parentTx}\n• Deposit: ${deposit}\n→ Please triage urgently.`
} else {
message = `⚠️ Retryable ticket needs triage:\n• Retryable: ${retryableUrl}\n• Timeout: ${timeoutStr}\n→ Please review and decide whether to redeem or ignore.`
message = `⚠️ Retryable ticket needs triage:\n• Retryable: ${retryableUrl}\n• Timeout: ${timeoutStr}\n• Parent Tx: ${parentTx}\n• Deposit: ${deposit}\n→ Please review and decide whether to redeem or ignore.`
}
} else if (decision === 'Should Redeem') {
if (!isNearExpiry(timeoutRaw)) continue // Skip if not near expiry
message = `🚨 Retryable marked for redemption and nearing expiry:\n• Retryable: ${retryableUrl}\n• Timeout: ${timeoutStr}\n→ Check why it hasn't been executed.`
if (!isNearExpiry(timeoutRaw)) continue
message = `🚨 Retryable marked for redemption and nearing expiry:\n• Retryable: ${retryableUrl}\n• Timeout: ${timeoutStr}\n• Parent Tx: ${parentTx}\n• Deposit: ${deposit}\n→ Check why it hasn't been executed.`
} else {
continue // skip unexpected decisions
continue
}

await postSlackMessage({ message })
Expand Down