Conversation
Contributor
douglance
commented
Jun 24, 2025

There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new function to post Slack messages using blocks instead of a plain text message, updates a dependency, removes an outdated file, and adjusts Slack message handling to support both message types.
- Added a new function (postSlackBlocks) in packages/utils/postSlackMessage.ts
- Updated Slack message handling in packages/retryable-monitor/handlers/slack/postSlackMessage.ts and reportFailedRetryables.ts
- Removed the legacy slackMessageGenerator.ts file
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/utils/postSlackMessage.ts | Added postSlackBlocks to support Slack blocks notifications. |
| packages/retryable-monitor/package.json | Added dotenv dependency. |
| packages/retryable-monitor/handlers/slack/slackMessageGenerator.ts | Removed legacy Slack message generator. |
| packages/retryable-monitor/handlers/slack/postSlackMessage.ts | Refactored to conditionally use blocks or messages. |
| packages/retryable-monitor/handlers/reportFailedRetryables.ts | Updated to generate and post Slack blocks. |
Comments suppressed due to low confidence (1)
packages/utils/postSlackMessage.ts:29
- [nitpick] Consider adding an explicit return type annotation for 'postSlackBlocks' for enhanced clarity and maintainability.
export const postSlackBlocks = ({
| }: { | ||
| slackToken: string | ||
| slackChannel: string | ||
| blocks: any[] |
There was a problem hiding this comment.
Consider refining the 'blocks' parameter type from 'any[]' to a more specific type to leverage TypeScript's type safety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.