Skip to content

only send notion-based slack alerts when --writeToNotion is enabled #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 3, 2025
Merged

only send notion-based slack alerts when --writeToNotion is enabled #74

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94f75ff
only send notion-based slack alerts when --writeToNotion is enabled
mahsamoosavi Sep 3, 2025
d33f9b7
address review comments
mahsamoosavi Sep 3, 2025
740d6f4
tweak the comment
mahsamoosavi Sep 3, 2025
ac721e7
fix typo
mahsamoosavi Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/retryable-monitor/handlers/handleFailedRetryablesFound.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,11 @@ export const handleFailedRetryablesFound = async (
ticket: OnFailedRetryableFoundParams,
writeToNotion: boolean
) => {
// report the Retryable in Slack
await reportFailedRetryables(ticket)
//old slack alert: only when not writing to Notion
if (!writeToNotion) {
await reportFailedRetryables(ticket)
}

// sync the Retryable to Notion
if (writeToNotion) {
const {
tokenDepositData,
Expand All @@ -28,7 +29,6 @@ export const handleFailedRetryablesFound = async (
const childChainProvider = new providers.JsonRpcProvider(
String(childChain.orbitRpcUrl)
)

const parentChainProvider = new providers.JsonRpcProvider(
String(childChain.parentRpcUrl)
)
Expand All @@ -38,7 +38,6 @@ export const handleFailedRetryablesFound = async (
childChain,
parentChainProvider
)

const l2CallValueFormatted = formattedCallValueFull
.replace('\n\t *Child chain callvalue:* ', '')
.trim()
Expand All @@ -58,6 +57,7 @@ export const handleFailedRetryablesFound = async (
6
)} ${symbol} ($${usdValue.toFixed(2)}) (${address})`
}

const { l2GasPrice, l2GasPriceAtCreation } = await getGasInfo(
childChainRetryableReport.createdAtBlockNumber,
childChainRetryableReport.id,
Expand Down