refactor: extract Slack messaging into dedicated package#87
Open
refactor: extract Slack messaging into dedicated package#87
Conversation
- Create new `packages/slack` package with all Slack-related code - Move createSlackPoster, postSlackMessage, sanitizeSlackMessage from utils - Update monitors to import from 'slack' instead of 'utils' - Export formatGitHubCIInfo from utils (used by slack package) - Remove @slack/web-api dependency from utils
- Add build:deps script to root for building utils and slack packages - Update monitor build scripts to use yarn --cwd ../.. build:deps - Add build script and dist output paths to slack package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@arbitrum-monitoring/slackpackage with all Slack-related codecreateSlackPoster- factory for creating monitor-specific Slack posterspostSlackMessage- core posting logic with CI info appendingsanitizeSlackMessage- redacts sensitive env vars from messagesgithubCIUtils- formats GitHub Actions run links@arbitrum-monitoring/slack:Test plan
npm run testin slack package passes (6 tests)