feat: enhance OFT token detection to block deposits#147
Open
dewanshparashar wants to merge 7 commits intomasterfrom
Open
feat: enhance OFT token detection to block deposits#147dewanshparashar wants to merge 7 commits intomasterfrom
dewanshparashar wants to merge 7 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
chrstph-dvx
previously approved these changes
Feb 3, 2026
fionnachan
reviewed
Feb 4, 2026
dewanshparashar
commented
Feb 4, 2026
| } catch (error) { | ||
| return false; | ||
| // Fallback: check if chain is in orbitChains list | ||
| return !!orbitChains[chainId]; |
Contributor
Author
There was a problem hiding this comment.
Updated this to check orbitChains as a fallback when the SDK doesn't recognize the chain. This ensures Orbit chains like Xai are correctly identified and tests pass.
fionnachan
reviewed
Feb 4, 2026
Comment on lines
+54
to
+55
| parentChainErc20Address: CommonAddress.ArbitrumOne['USDC.e'], | ||
| parentChainId: ChainId.Ethereum, |
Member
There was a problem hiding this comment.
this doesn't make any sense because the parent chain is Ethereum so the ERC20 address should be the one on Ethereum instead of Arbitrum One
Comment on lines
-1
to
-2
| // tokens that can't be bridged to Arbitrum (maybe coz they have their native protocol bridges and custom implementation or they are being discontinued) | ||
| // the UI doesn't let users deposit such tokens. If bridged already, these can only be withdrawn. |
Member
There was a problem hiding this comment.
these comments should be useful to keep?
| l2Address: '0xe575586566b02a16338c199c23ca6d295d794e66', | ||
| }, | ||
| { | ||
| symbol: 'pyUSD', |
Comment on lines
+263
to
+265
| l2CustomAddr: '0xfab5891ed867a1195303251912013b92c4fc3a1d', | ||
| l1Address: '0xa2c323fe5a74adffad2bf3e007e36bb029606444', | ||
| l2Address: '0x327006c8712fe0abdbbd55b7999db39b0967342e', |
Member
There was a problem hiding this comment.
where do these come from??
the l2CustomAddr you gave is their OFT adapter address
we should use the innerTokenAddress
Suggested change
| l2CustomAddr: '0xfab5891ed867a1195303251912013b92c4fc3a1d', | |
| l1Address: '0xa2c323fe5a74adffad2bf3e007e36bb029606444', | |
| l2Address: '0x327006c8712fe0abdbbd55b7999db39b0967342e', | |
| l2CustomAddr: '0x46850ad61c2b7d64d08c9c754f45254596696984', | |
| l1Address: '0x6c3ea9036406852006290770bedfcaba0e23a0e8', | |
| l2Address: '0x327006c8712fe0abdbbd55b7999db39b0967342e', |
| const tokenEntries = metadata[tokenSymbol]; | ||
| if (!Array.isArray(tokenEntries)) continue; | ||
|
|
||
| for (const tokenEntry of tokenEntries) { |
Member
There was a problem hiding this comment.
the content in this for loop seems very repetitive and can be simplified with some helper functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo of OffchainLabs/arbitrum-token-bridge#2537 in the Portal repo