test(bridge): Add integration tests for transfer panel by chrstph-dvx · Pull Request #182 · OffchainLabs/arbitrum-portal

chrstph-dvx · 2026-02-25T18:52:57Z

Summary

Steps to test

vercel · 2026-02-25T18:53:01Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
arbitrum-portal	Ready	Preview	Apr 22, 2026 5:21pm

Copilot

Pull request overview

This PR adds comprehensive integration tests for the TransferPanel component, which handles token transfers between different blockchain networks. The tests verify that the correct tokens are displayed and available for selection across various transfer scenarios including default token transfers, USDC transfers, ETH/WETH overrides, and token swaps.

Changes:

Added integration test infrastructure with separate Vitest configuration and setup files
Implemented 569-line integration test suite covering multiple transfer scenarios across Ethereum, ApeChain, and Superposition networks
Fixed a bug in useNativeCurrency.ts where the wrong address was being used to fetch ERC20 data
Enhanced useGasEstimates.ts to properly handle different route types (canonical, LiFi, CCTP, OftV2)
Fixed HTML semantic issues in NetworkSelectionContainer by replacing nested <p> tags with <div> and <span>

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
vitest.integration.config.ts	New Vitest configuration for integration tests with 120s timeout and happy-dom environment
vitest.integration.setup.ts	Setup file that configures axios defaults, mocks animations API, and sets public RPC URLs
vitest.config.ts	Updated to exclude integration tests and add @/components alias
integration-test-wrapper.tsx	Test wrapper utility providing Overmind, QueryParam, Wagmi, and SWR contexts
TransferPanel.integration.test.tsx	Comprehensive integration tests for TransferPanel covering default, USDC, ETH/WETH, and swap scenarios
useNativeCurrency.ts	Added try-catch error handling and fallback to config data when ERC20 fetch fails
useGasEstimates.ts	Enhanced route selection logic to support LiFi, CCTP, and OftV2 route types
DestinationTokenButton.tsx	Simplified to use networks.destinationChainProvider directly
NetworkSelectionContainer.tsx	Fixed invalid HTML nesting by changing `<p>` to `<div>` and nested `<p>` to `<span>`
package.json (both)	Added test:integration scripts and jsdom-testing-mocks dependency
yarn.lock	Updated dependencies including @WalletConnect, @reown/appkit, and various cryptographic libraries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

chrstph-dvx · 2026-02-25T18:56:05Z


-  const { childChainProvider } = useNetworksRelationship(networks);
-  const nativeCurrency = useNativeCurrency({ provider: childChainProvider });
+  const nativeCurrency = useNativeCurrency({ provider: networks.destinationChainProvider });


It wasn't a big issue, but destination provider is more correct than child here

this is wrong. it introduces a regression bug for custom native token chain withdrawals.

chrstph-dvx · 2026-02-25T18:57:04Z

        <span className="truncate text-base">{network.name}</span>

-        <p className="text-xs leading-none text-white/70">
+        <div className="text-xs leading-none text-white/70">


Small fix: it was spamming the console, about p being a parent of p

chrstph-dvx · 2026-03-10T13:16:37Z

    [key: string]: string | string[] | undefined;
  },
  baseUrl: string,
+) {


This function was called on the server, integration test is skipping it. So this util was extracted (without the redirect) to be called in integration test.

fionnachan

this PR shouldn't change any logic in the code because a seemingly small change could break the app

let's only introduce the tests without making any changes unless they are purely HTML element changes

fionnachan · 2026-04-21T11:19:55Z

formatting failure on L434

fionnachan · 2026-04-21T11:20:22Z

-      (sourceChainNativeCurrency.isCustom && destinationChainNativeCurrency.isCustom) ||
-      networks.sourceChain.id === ChainId.ApeChain
-    ) {
+    if (sourceChainNativeCurrency.isCustom && destinationChainNativeCurrency.isCustom) {


what's this change for?

fionnachan · 2026-04-21T11:23:14Z


-  const { childChainProvider } = useNetworksRelationship(networks);
-  const nativeCurrency = useNativeCurrency({ provider: childChainProvider });
+  const nativeCurrency = useNativeCurrency({ provider: networks.destinationChainProvider });


this is wrong. it introduces a regression bug for custom native token chain withdrawals.

- update useGasEstimates to be route-aware

Copilot AI review requested due to automatic review settings February 25, 2026 18:52

Copilot started reviewing on behalf of chrstph-dvx February 25, 2026 18:53 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

vercel Bot deployed to Preview February 25, 2026 18:57 View deployment

chrstph-dvx marked this pull request as draft February 25, 2026 19:08

vercel Bot deployed to Preview February 25, 2026 19:49 View deployment

vercel Bot deployed to Preview February 26, 2026 12:14 View deployment

vercel Bot deployed to Preview March 3, 2026 17:51 View deployment

chrstph-dvx force-pushed the integration-tests branch from 41b199c to 35b70e7 Compare March 5, 2026 15:04

vercel Bot deployed to Preview March 5, 2026 15:09 View deployment

chrstph-dvx force-pushed the integration-tests branch from 35b70e7 to ad792ce Compare March 6, 2026 14:17

vercel Bot deployed to Preview March 6, 2026 14:22 View deployment

vercel Bot deployed to Preview March 9, 2026 11:38 View deployment

chrstph-dvx force-pushed the integration-tests branch from 5f25ed7 to 70cdf98 Compare March 9, 2026 12:26

vercel Bot deployed to Preview March 9, 2026 12:31 View deployment

chrstph-dvx commented Mar 19, 2026

View reviewed changes

chrstph-dvx force-pushed the integration-tests branch from 70cdf98 to ecc163e Compare March 30, 2026 13:48

chrstph-dvx marked this pull request as ready for review March 30, 2026 13:48

vercel Bot deployed to Preview March 30, 2026 13:53 View deployment

chrstph-dvx force-pushed the integration-tests branch from ecc163e to e77f2b0 Compare April 20, 2026 12:37

vercel Bot deployed to Preview April 20, 2026 12:42 View deployment

fionnachan reviewed Apr 21, 2026

View reviewed changes

vercel Bot deployed to Preview April 22, 2026 16:57 View deployment

chrstph-dvx added 6 commits April 22, 2026 17:16

test(bridge): Add integration tests for transfer panel

d8ae09a

- update useGasEstimates to be route-aware

fix tokenRow

1f9f8c7

Run in parallel

f8d6b67

Colocate test cases

314b4e7

Run query param sanitization

50660eb

Add test for token panel

b090b2c

chrstph-dvx added 3 commits April 22, 2026 17:17

cleanup

0e0ff64

cleanup

faa4a61

Address comments

014bd35

chrstph-dvx force-pushed the integration-tests branch from 89d9148 to 014bd35 Compare April 22, 2026 17:17

vercel Bot deployed to Preview April 22, 2026 17:21 View deployment

Conversation

chrstph-dvx commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Steps to test

Uh oh!

vercel Bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chrstph-dvx Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

fionnachan Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

chrstph-dvx Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

chrstph-dvx Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

fionnachan left a comment

Choose a reason for hiding this comment

Uh oh!

fionnachan Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

fionnachan Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

fionnachan Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chrstph-dvx commented Feb 25, 2026 •

edited

Loading

vercel Bot commented Feb 25, 2026 •

edited

Loading