test(WIP): migrate from cypress to playwright by fionnachan · Pull Request #214 · OffchainLabs/arbitrum-portal

fionnachan · 2026-03-09T20:14:10Z

No description provided.

vercel · 2026-03-09T20:14:16Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
arbitrum-portal	Ready	Preview	Jun 25, 2026 5:00pm

Copilot

Pull request overview

Migrates the arb-token-bridge-ui E2E test harness from Synpress v3 to Synpress v4, updating Cypress/Synpress integration, MetaMask command APIs, and CI execution to support the new wallet cache architecture.

Changes:

Bump @synthetixio/synpress to v4 and update Cypress plugin/support initialization (configureSynpressForMetaMask, synpressCommandsForMetaMask).
Replace v3 MetaMask Cypress commands with v4 equivalents across support utilities and E2E specs.
Add Synpress wallet-cache setup (wallet-setup files + CI step) and adjust E2E runner scripts/config (incl. testIsolation: false).

Reviewed changes

Copilot reviewed 20 out of 24 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
packages/arb-token-bridge-ui/tests/tsconfig.json	Removes v3 Synpress support types from test TS config.
packages/arb-token-bridge-ui/tests/support/index.ts	Switches to v4 Synpress Cypress support + rewrites MetaMask bootstrap flow.
packages/arb-token-bridge-ui/tests/support/common.ts	Replaces v3 “accept access” helper with v4 `connectToDapp`.
packages/arb-token-bridge-ui/tests/support/commands.ts	Updates login/network switching and tx approval/rejection commands for v4.
packages/arb-token-bridge-ui/tests/e2e/specs/withdrawNativeToken.cy.ts	Updates tx confirmation calls to v4 APIs.
packages/arb-token-bridge-ui/tests/e2e/specs/withdrawERC20.cy.ts	Updates tx confirmation calls to v4 APIs.
packages/arb-token-bridge-ui/tests/e2e/specs/withdrawCctp.cy.ts	Updates tx/network switching calls to v4 APIs.
packages/arb-token-bridge-ui/tests/e2e/specs/redeemRetryable.cy.ts	Updates tx confirmation calls to v4 APIs.
packages/arb-token-bridge-ui/tests/e2e/specs/depositCctp.cy.ts	Updates tx confirm/reject calls and comments for v4 APIs.
packages/arb-token-bridge-ui/tests/e2e/specs/approveToken.cy.ts	Updates tx rejection call to v4 API.
packages/arb-token-bridge-ui/tests/e2e/getCommonSynpressConfig.ts	Sets `testIsolation: false` per Synpress v4 requirements.
packages/arb-token-bridge-ui/tests/e2e/cypress.d.ts	Removes v3 Synpress type reference.
packages/arb-token-bridge-ui/test/wallet-setup/tsconfig.json	Adds TS config for wallet cache setup scripts.
packages/arb-token-bridge-ui/test/wallet-setup/basic.setup.ts	Adds Synpress wallet cache setup using Playwright MetaMask helper.
packages/arb-token-bridge-ui/synpress.config.ts	Replaces v3 plugin with `configureSynpressForMetaMask`.
packages/arb-token-bridge-ui/synpress.cctp.config.ts	Replaces v3 plugin with `configureSynpressForMetaMask`.
packages/arb-token-bridge-ui/synpress-plugins.d.ts	Removes v3 plugin module declaration.
packages/arb-token-bridge-ui/package.json	Bumps `@synthetixio/synpress` to `4.0.5`.
package.json	Adds wallet-cache script and switches E2E execution to `cypress run` flow.
SYNPRESS_V4_MIGRATION.md	Documents v3→v4 migration steps and command mapping.
CLAUDE.md	Adds guidance about not reading `.env` files.
.gitignore	Ignores Synpress cache directory.
.github/workflows/e2e-tests.yml	Adds CI step to build Synpress wallet cache before running E2E tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-09T21:09:02Z

+  cy.switchNetwork({ networkName: networkNameWithDefault, isTestnet: true }).then(() => {
    _startWebApp();
  });


login() now always calls cy.switchNetwork({ ..., isTestnet: true }). Several specs call cy.login({ networkName: 'Ethereum' }) to run against mainnet; forcing isTestnet: true will likely prevent switching to Ethereum mainnet. Consider deriving isTestnet from networkNameWithDefault (or accepting it as a parameter) so mainnet and testnet flows both work.

Copilot · 2026-03-09T21:09:03Z

+Cypress.on('uncaught:exception', () => false);
+


Cypress.on('uncaught:exception', () => false) suppresses all uncaught exceptions, which can mask real application/test failures and make debugging harder. Prefer filtering to known/expected MetaMask/Synpress errors (e.g., by inspecting the error message) or removing this handler and fixing the underlying exception source.

Copilot · 2026-03-09T21:09:03Z

+- New file: `packages/arb-token-bridge-ui/test/wallet-setup/basic.setup.ts`
+- Uses `defineWalletSetup()` and `MetaMask` class to import wallet from seed phrase
+


This step says the wallet is imported from a seed phrase, but basic.setup.ts uses importWalletFromPrivateKey(). Update the migration doc to reflect the actual implementation (private key) to avoid confusion for future maintenance.

Copilot · 2026-03-09T21:09:03Z

+      - name: Build Synpress wallet cache
+        run: xvfb-run npx synpress ./packages/arb-token-bridge-ui/test/wallet-setup
+        env:
+          DISPLAY: :0.0
+          PRIVATE_KEY_USER: ${{ secrets.E2E_PRIVATE_KEY_USER }}
+


The workflow builds the Synpress wallet cache here, but the test:e2e / test:e2e:cctp scripts also run yarn synpress:cache first. This duplication adds runtime and another potential failure point; consider removing this workflow step or gating the script cache build behind an env flag when running in CI.

Copilot · 2026-03-09T21:09:03Z

+// The wallet cache only bootstraps MetaMask with an initialized state.
+// The actual test wallet (PRIVATE_KEY_USER) is imported at runtime in support/index.ts
+// via cy.importWalletFromPrivateKey().
+const PRIVATE_KEY = process.env.PRIVATE_KEY_USER;


The comment says the wallet cache only initializes MetaMask and that the actual test wallet is imported at runtime via cy.importWalletFromPrivateKey(), but this setup file already calls metamask.importWalletFromPrivateKey(PRIVATE_KEY_USER). Either update the comment (and migration doc) or adjust the setup so the cache build doesn’t import the same wallet that tests later import again.

Expand the Playwright e2e foundation to cover the whole suite and remove the shared Cypress harness: - globalSetup ports the Cypress setupNodeEvents chain prep (ERC20/WETH deploy + fund, approvals, custom-gas-token, redeem-retryable tx) and fires the activity/assertion loops; globalSetup.cctp covers the CCTP testnet setup - fixtures use a worker-scoped MetaMask context (set up once per worker) pinned to MetaMask 11.15.0, plus an e2eEnv config fixture - support/common.ts and support/actions.ts port the network helpers and all Cypress custom commands as page-based async functions - remove synpress.config.ts, synpress.cctp.config.ts, tests/support, and the Cypress-only config/types

Replace the Cypress GitHub Action with a Playwright run (start app, wait, then `pnpm test:e2e <spec>`, orbit variants via env), update the spec matrix to Playwright filenames, and drop the unused cctp.json.

fionnachan · 2026-07-09T11:07:25Z

using #372.

vercel Bot deployed to Preview March 9, 2026 20:17 View deployment

fionnachan changed the title ~~test: synpress v4~~ test(WIP): synpress v4 Mar 9, 2026

fionnachan marked this pull request as ready for review March 9, 2026 21:02

Copilot AI review requested due to automatic review settings March 9, 2026 21:02

Copilot started reviewing on behalf of fionnachan March 9, 2026 21:03 View session

fionnachan added bug Something isn't working and removed bug Something isn't working labels Mar 9, 2026

Copilot AI reviewed Mar 9, 2026

View reviewed changes

vercel Bot deployed to Preview March 19, 2026 15:05 View deployment

vercel Bot deployed to Preview March 19, 2026 17:18 View deployment

vercel Bot deployed to Preview May 15, 2026 11:01 View deployment

vercel Bot deployed to Preview May 15, 2026 12:06 View deployment

fionnachan added 17 commits June 24, 2026 19:14

playwright

a9ea25e

test(bridge): migrate login e2e test to Playwright

62f52c1

test(bridge): migrate switchNetworks e2e test to Playwright

3b0b17c

test(bridge): migrate depositNativeToken e2e test to Playwright

bc720be

test(bridge): migrate withdrawNativeToken e2e test to Playwright

ae88230

test(bridge): migrate depositERC20 e2e test to Playwright

2469a8b

test(bridge): migrate withdrawERC20 e2e test to Playwright

7e91021

test(bridge): migrate batchDeposit e2e test to Playwright

4cccb68

test(bridge): migrate approveToken e2e test to Playwright

5fe0a98

test(bridge): migrate importToken e2e test to Playwright

47b4bf6

test(bridge): migrate txHistory e2e test to Playwright

2c48488

test(bridge): migrate readClassicDeposits e2e test to Playwright

6a2385c

test(bridge): migrate redeemRetryable e2e test to Playwright

795ca3f

test(bridge): migrate urlQueryParam e2e test to Playwright

3eaab8d

test(bridge): migrate depositCctp e2e test to Playwright

8e59e69

test(bridge): migrate withdrawCctp e2e test to Playwright

88813e3

ci(bridge): run e2e tests with Playwright

33c56df

Replace the Cypress GitHub Action with a Playwright run (start app, wait, then `pnpm test:e2e <spec>`, orbit variants via env), update the spec matrix to Playwright filenames, and drop the unused cctp.json.

fionnachan force-pushed the synpress-migration branch from b521343 to eae0045 Compare June 25, 2026 15:21

vercel Bot had a problem deploying to Preview June 25, 2026 15:21 Failure

github-advanced-security AI found potential problems Jun 25, 2026

View reviewed changes

Comment thread packages/arb-token-bridge-ui/tests/e2e/playwright/support/actions.ts Fixed

fionnachan force-pushed the synpress-migration branch from eae0045 to 33c56df Compare June 25, 2026 15:25

vercel Bot had a problem deploying to Preview June 25, 2026 15:25 Failure

build(deps): update package.json and lock file

535de19

vercel Bot deployed to Preview June 25, 2026 16:54 View deployment

fionnachan added 2 commits June 25, 2026 17:58

test: fix amount parsing regex

e778bad

build(deps): bump playwright

c3dca39

vercel Bot deployed to Preview June 25, 2026 17:00 View deployment

fionnachan changed the title ~~test(WIP): synpress v4~~ test(WIP): migrate from cypress to playwright Jun 26, 2026

fionnachan mentioned this pull request Jun 26, 2026

test(bridge): migrate from Cypress to Playwright #372

Open

fionnachan closed this Jul 9, 2026

fionnachan deleted the synpress-migration branch July 9, 2026 11:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(WIP): migrate from cypress to playwright#214

test(WIP): migrate from cypress to playwright#214
fionnachan wants to merge 21 commits into
masterfrom
synpress-migration

fionnachan commented Mar 9, 2026

Uh oh!

vercel Bot commented Mar 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Uh oh!

fionnachan commented Jul 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		- New file: `packages/arb-token-bridge-ui/test/wallet-setup/basic.setup.ts`
		- Uses `defineWalletSetup()` and `MetaMask` class to import wallet from seed phrase

		Cypress.on('uncaught:exception', () => false);

Uh oh!

Conversation

fionnachan commented Mar 9, 2026

Uh oh!

vercel Bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fionnachan commented Jul 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel Bot commented Mar 9, 2026 •

edited

Loading