Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Implements client-side browser notifications to alert users of transaction status changes throughout the bridge lifecycle. Notifications trigger on: - Transaction signing and broadcast - L1/L2 status transitions - Withdrawal confirmation and execution - Transaction failures Uses service worker and browser Notification API with no external dependencies. Users opt-in via Settings dialog. Notifications persist in OS notification center.
douglance
changed the title
fionnachan
reviewed
Oct 7, 2025
| const withdrawalStatusMessages = { | ||
| 'Unconfirmed': 'Withdrawal Initiated', | ||
| 'Confirmed': 'Withdrawal Confirmed - Ready to Claim', | ||
| 'Executed': 'Withdrawal Claimed Successfully', |
Member
There was a problem hiding this comment.
notification is not showing when claiming old transaction
|
|
||
| const updateCachedTransaction = useCallback( | ||
| (newTx: MergedTransaction) => { | ||
| // Find the old transaction from cache to detect status changes |
Member
There was a problem hiding this comment.
notification code probably should move out of updateCachedTransaction?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements client-side browser notifications to alert users of transaction status changes throughout the bridge lifecycle. Notifications trigger on:
Uses service worker and browser Notification API with no external dependencies. Users opt-in via Settings dialog. Notifications persist in OS notification center.