Skip to content

Conversation

douglance
Copy link
Contributor

  • minimal change in order to turn the repository into a monorepo.
  • we migrate the project at the root into packages/sdk and move its unique config there
  • we'll split out the scripts folder in a future PR

@douglance douglance requested review from brtkx and spsjvc December 10, 2024 19:14
@cla-bot cla-bot bot added the cla-signed label Dec 10, 2024
@spsjvc spsjvc changed the title feat: sets up monorepo refactor: set up monorepo Dec 13, 2024
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
# yarn lockfile v1


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm how did this end up here? can you revert it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was using this to break the cache. fixed 88b994a

"files": [
"dist/**/*"
],
"resolutions": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we move resolutions for runtime dependencies to the package's package.json?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking it would be nice to have them shared among packages, but I guess it's probably better to just deal with issues individually if they come up. so i moved the resolutions down to the sdk package 88b994a

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh actually, those are all there for audit-ci fixing purposes, so we want them there c80b628

import * as path from 'path'

export const loadEnv = () => {
dotenv.config({ path: path.resolve(__dirname, '../../../../../.env') })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this work properly both in the case when you're running commands at the root level of the monorepo, and when you cd into the package and run it there?

Copy link
Contributor Author

@douglance douglance Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does work from both locations. __dirname is the location of this file.

@douglance douglance requested a review from spsjvc December 13, 2024 20:18
@spsjvc spsjvc merged commit c47d1f5 into main Dec 17, 2024
21 checks passed
@spsjvc spsjvc deleted the dl/monorepo branch December 17, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants