Skip to content

add parent provider #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

add parent provider #598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2aca9b6
add parent provider
spsjvc May 20, 2025
f1f33ab
bump v
spsjvc May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@arbitrum/sdk",
"version": "4.0.4",
"version": "4.0.5-alpha.0",
"description": "Typescript library client-side interactions with Arbitrum",
"author": "Offchain Labs, Inc.",
"license": "Apache-2.0",
Expand Down
7 changes: 4 additions & 3 deletions packages/sdk/src/lib/assetBridger/erc20Bridger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ export interface Erc20WithdrawParams extends EthWithdrawParams {
export type ParentToChildTxReqAndSignerProvider =
ParentToChildTransactionRequest & {
parentSigner: Signer
parentProvider?: Provider
childProvider: Provider
overrides?: Overrides
}
Expand Down Expand Up @@ -780,9 +781,9 @@ export class Erc20Bridger extends AssetBridger<
)
}

const parentProvider = SignerProviderUtils.getProviderOrThrow(
params.parentSigner
)
const parentProvider =
params.parentProvider ??
SignerProviderUtils.getProviderOrThrow(params.parentSigner)

const erc20ParentAddress = isParentToChildTransactionRequest(params)
? getErc20ParentAddressFromParentToChildTxRequest(params)
Expand Down
6 changes: 5 additions & 1 deletion packages/sdk/src/lib/assetBridger/ethBridger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,13 @@ export interface EthWithdrawParams {

export type EthDepositParams = {
/**
* Parent network provider or signer
* Parent network signer
*/
parentSigner: Signer
/**
* Parent network provider, otherwise `parentSigner.provider` will be used
*/
parentProvider?: Provider
/**
* The amount of ETH or tokens to be deposited
*/
Expand Down