Skip to content

fix: retryable gas estimation failing due to uncaught eth_call revert data return format #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: retryable gas estimation failing due to uncaught eth_call revert data return format #605

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c51d760
catch other eth call error format
godzillaba Jul 15, 2025
25d69a5
improve comment
godzillaba Jul 15, 2025
4914492
format
godzillaba Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions packages/sdk/src/lib/dataEntities/retryableData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Interface } from '@ethersproject/abi'
import { BigNumber } from 'ethers'
import { isDefined } from '../utils/lib'
import { isHexString } from 'ethers/lib/utils'

// TODO: add typechain support
const errorInterface = new Interface([
Expand Down Expand Up @@ -82,7 +83,37 @@ export class RetryableDataTools {
body?: string
data?: string
}

// there may be a json string at this key of the form:
// {
// "error": {
// "code": -32015,
// "message": "...",
// "data": "0x..."
// }
// }
// nethermind may return revert data this way
body?: string
}
}

try {
const possibleErrorBody = JSON.parse(typedError.error?.body || '') as {
error?: {
code?: number
message?: string
data?: string
}
}

if (
possibleErrorBody.error?.code === -32015 &&
isHexString(possibleErrorBody.error.data)
) {
return possibleErrorBody.error.data
}
} catch {
// ignore parsing error
}

if (typedError.data) {
Expand Down
Loading