Skip to content

fix: ensure correct network before any transaction #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix: ensure correct network before any transaction #2498

wants to merge 8 commits into from

Conversation

chrstph-dvx
Copy link
Contributor

@chrstph-dvx chrstph-dvx commented Jun 3, 2025 •
edited
Loading

Summary

Steps to test

@cla-bot cla-bot bot added the cla-signed label Jun 3, 2025
@vercel Vercel
Copy link

vercel bot commented Jun 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arbitrum-token-bridge ✅ Ready (Inspect) Visit Preview Jul 28, 2025 9:50am

@chrstph-dvx chrstph-dvx force-pushed the fix-check-for-network-before-tx branch from ce42c8e to ee32f1b Compare June 4, 2025 09:44
@chrstph-dvx chrstph-dvx requested review from brtkx and douglance June 6, 2025 12:30
douglance
douglance reviewed Jun 6, 2025
View reviewed changes
Copy link
Contributor

@douglance douglance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are three different ways to get source chain id. seems like that should be in the transfer starter constructor. but not worth addressing in this PR. just thought it was interesting.

@chrstph-dvx chrstph-dvx force-pushed the fix-check-for-network-before-tx branch from 7b279ff to c7a2435 Compare June 9, 2025 09:44
@chrstph-dvx chrstph-dvx requested a review from douglance June 9, 2025 09:44
@chrstph-dvx chrstph-dvx force-pushed the fix-check-for-network-before-tx branch from c7a2435 to ace2423 Compare June 10, 2025 14:10
@chrstph-dvx chrstph-dvx force-pushed the fix-check-for-network-before-tx branch 2 times, most recently from cd05671 to d69e026 Compare June 16, 2025 09:02
@chrstph-dvx chrstph-dvx force-pushed the fix-check-for-network-before-tx branch from d69e026 to df4759c Compare June 27, 2025 13:25
@chrstph-dvx chrstph-dvx force-pushed the fix-check-for-network-before-tx branch from df4759c to 7cfa4d9 Compare July 28, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spsjvc spsjvc spsjvc left review comments

@brtkx brtkx Awaiting requested review from brtkx

@douglance douglance Awaiting requested review from douglance

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrstph-dvx @douglance @spsjvc