Skip to content

refactor: pass in ui driver context to executor #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
Merged

refactor: pass in ui driver context to executor #2522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d734fc7
refactor: pass in ui driver context to executor
spsjvc Jun 13, 2025
5b08d85
fix
spsjvc Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/arb-token-bridge-ui/src/components/TransferPanel/TransferPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ export function TransferPanel() {
return true
}

const stepExecutor: UiDriverStepExecutor = async step => {
const stepExecutor: UiDriverStepExecutor = async (context, step) => {
if (process.env.NODE_ENV === 'development') {
console.log(step)
}
Expand Down
4 changes: 2 additions & 2 deletions packages/arb-token-bridge-ui/src/ui-driver/UiDriver.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ it('successfully does step execution', async () => {
yield { type: 'start' }
}

const executor: UiDriverStepExecutor = async function (step) {
const executor: UiDriverStepExecutor = async function (_, step) {
if (step.type === 'start') {
counter += 1
}
Expand All @@ -39,7 +39,7 @@ it('successfully does early return', async () => {
yield { type: 'start' }
}

const executor: UiDriverStepExecutor = async function (step) {
const executor: UiDriverStepExecutor = async function (_, step) {
if (step.type === 'start') {
counter += 1
}
Expand Down
3 changes: 2 additions & 1 deletion packages/arb-token-bridge-ui/src/ui-driver/UiDriver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ export type UiDriverStepGenerator<TStep extends UiDriverStep = UiDriverStep> = (
) => AsyncGenerator<TStep, void, UiDriverStepResultFor<TStep['type']>>

export type UiDriverStepExecutor<TStep extends UiDriverStep = UiDriverStep> = (
context: UiDriverContext,
step: TStep
) => Promise<UiDriverStepResultFor<TStep['type']>>

Expand Down Expand Up @@ -100,7 +101,7 @@ export async function drive<TStep extends UiDriverStep>(
}

// execute current step and obtain the result
const result = await executor(step)
const result = await executor(context, step)

// pass the result back into the generator
nextStep = await flow.next(result)
Expand Down
Loading