-
Notifications
You must be signed in to change notification settings - Fork 218
refactor: add wagmi tx step type to ui driver #2524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
spsjvc
wants to merge
4
commits into
master
Choose a base branch
from
ui-driver-viem-tx-type
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jun 13, 2025
ef5ff09
to
ba8bd53
Compare
ba8bd53
to
c082934
Compare
85db227
to
361b4ba
Compare
c082934
to
c87c77f
Compare
361b4ba
to
dda9e85
Compare
spsjvc
commented
Jun 17, 2025
Comment on lines
+387
to
+400
const handleTxSigningError = (error: unknown, txRequestLabel: string) => { | ||
// capture error and show toast for anything that's not user rejecting error | ||
if (!isUserRejectedError(error)) { | ||
handleError({ | ||
error, | ||
label: txRequestLabel, | ||
category: 'transaction_signing' | ||
}) | ||
|
||
errorToast(`${(error as Error)?.message ?? error}`) | ||
} | ||
|
||
return { error: error as unknown as Error } | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error handling code is reused between tx_ethers
and tx_wagmi
e7e8de0
to
a1a1d1f
Compare
1e7a1e9
to
3136884
Compare
3136884
to
faedf9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack created with Aviator.
master
Summary
Steps to test