feat: enhance OFT token detection to block deposits #2537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dewanshparashar
changed the title
dewanshparashar
changed the title
…e into feat-enhance-oft-token-detection
…e into feat-enhance-oft-token-detection
chrstph-dvx
reviewed
Jun 26, 2025
| ) { | ||
| const parentProvider = getProviderForChainId(parentChainId) | ||
| ): Promise<boolean> { | ||
| const chainIdToLzName: Record<number, string | undefined> = { |
There was a problem hiding this comment.
Looks like all values are defined, we can narrow down the type here
| // } | ||
| // } | ||
|
|
||
| const response = await axios.get( |
There was a problem hiding this comment.
Any reason we use axios over fetch here? We don't seem to leverage any of the utilities of axios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue that triggered this
User was able to transfer ENA token (which is OFT) via Canonical Arbitrum Bridge - which sent it to canonical arbitrum-bridged token counterpart instead of the custom (Arb)ENA token that was deployed via OFT. This prompted us to make our
isLayerZeroToken()method more robust, which is supposed to block such deposits.In this PR
Description
The previous on-chain OFT detection was unreliable, as it missed tokens like ENA that don't expose the
oftVersion()method. This caused user funds to be bridged to incorrect, non-OFT contracts on Arbitrum.The new solution uses the LayerZero metadata API as the definitive source for identifying OFT tokens. This ensures accurate detection and prevents improper deposits by marking these tokens as withdraw-only (except USDT0 which is a special case as we have an existing integration for it's transfers).
How to test
Try depositing ENA token (0x57e114b691db790c35207b2e685d4a43181e6061) from Ethereum to Arbitrum One - it should be blocked. Withdrawals should be okay.
Closes FS-1277