feat: indexer poc #2545

brtkx · 2025-06-25T13:24:28Z

No description provided.

vercel · 2025-06-25T13:24:33Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Updated (UTC)
arbitrum-token-bridge	Error		Sep 3, 2025 3:07pm

brtkx · 2025-09-02T13:19:11Z

packages/arb-token-bridge-ui/src/components/App/ponder.ts

@@ -0,0 +1,30 @@
+import { createClient } from '@ponder/client'


Need to check with @douglance what we actually need here

brtkx · 2025-09-02T13:21:31Z

packages/arb-token-bridge-ui/src/hooks/useTransactionHistory.ts

  const { isFeatureDisabled } = useDisabledFeatures()
  const isTxHistoryEnabled = !isFeatureDisabled(DisabledFeatures.TX_HISTORY)

+  const indexerResult = useIndexerHistory(address)


The idea is to only run indexer with the feature flag enabled. We return indexerResult if indexer flag is true, otherwise legacy results.

We also use the indexer flag when fetching indexer and legacy results so that:

we only fetch legacy if indexer === false || indexer === undefined

we only fetch indexer if indexer === true

brtkx · 2025-09-02T13:22:38Z

packages/arb-token-bridge-ui/src/components/TransactionHistory/useIndexerHistory.ts

+  parentChainId: number
+}
+
+type EthIndexerTransfer = PartialTransfer & {


I mirrored whatever indexer was returning, but maybe we can now get types from some package @douglance?

If not then we have to keep them defined here.

brtkx · 2025-09-02T13:23:07Z

packages/arb-token-bridge-ui/src/components/TransactionHistory/useIndexerHistory.ts

+
+type IndexerTransfer = EthIndexerTransfer | Erc20IndexerTransfer
+
+function getIndexerTransferStatus(tx: IndexerTransfer) {


Took from indexer some time ago but these may have changed

Need to map them to whatever we use in our UI

brtkx · 2025-09-02T13:23:23Z

packages/arb-token-bridge-ui/src/components/TransactionHistory/useIndexerHistory.ts

+  }
+}
+
+function getIndexerDepositStatus(tx: IndexerTransfer): DepositStatus {


same here, may have changed

brtkx · 2025-09-02T13:25:12Z

packages/arb-token-bridge-ui/src/components/TransactionHistory/useIndexerHistory.ts

+  }
+}
+
+type TokenDetails = {


Indexer only gives us token address because it would take a long time to fetch token data and store it. We need to fetch the token data ourselves.

see L162

brtkx · 2025-09-02T13:25:47Z

packages/arb-token-bridge-ui/src/components/TransactionHistory/useIndexerHistory.ts

+  decimals: number
+}
+
+function transformIndexerTransfer(params: {


Some overrides for ETH or ERC20

brtkx · 2025-09-02T13:27:05Z

packages/arb-token-bridge-ui/src/components/TransactionHistory/useIndexerHistory.ts

+    async ([_indexerTransactions, _tokensFromLists]) => {
+      const result: { [key in string]: TokenDetails } = {}
+
+      for (let i = 0; i < _indexerTransactions.length; i++) {


This is not great but I did it just for PoC to work.

Basically as mentioned before, indexer is not giving us ERC20 data, so we fetch ourselves. We need to do it for each ERC20 transaction we get from indexer. We may be able to do something smarter here.

brtkx · 2025-09-02T13:27:54Z

packages/arb-token-bridge-ui/src/components/TransactionHistory/useIndexerHistory.ts

+  }, [pendingTransfers, completedTransfers])
+
+  // todo: cache
+  const { data: tokenDetailsMap } = useSWRImmutable(


ERC20 data because indexer doesn't have it.

brtkx · 2025-09-02T13:28:21Z

packages/arb-token-bridge-ui/src/components/TransactionHistory/useIndexerHistory.ts

+    }
+  )
+
+  const { data: transactions = [] } = useSWR(


Final data which includes token data for ERC20 transactions

brtkx · 2025-09-02T13:29:14Z

packages/arb-token-bridge-ui/src/components/TransactionHistory/useIndexerHistory.ts

+    ([_indexerTransactions, _tokenDetailsMap]) => {
+      return _indexerTransactions.map(tx => {
+        if (tx.type === 'ETH') {
+          return transformIndexerTransfer({ tx })


With overrides we can use the same function for ETH and ERC20. The only difference is if it's ERC20 then tokenDetails is required, otherwise it needs to be skipped for ETH.

brtkx · 2025-09-02T13:34:21Z

packages/arb-token-bridge-ui/src/hooks/useTransactionHistory.ts

+  const isIndexerEnabled = isExperimentalFeatureEnabled('indexer')
+
+  if (isIndexerEnabled) {
+    return { ...indexerResult, addPendingTransaction, updatePendingTransaction }


addPendingTransaction and updatePendingTransaction stays as is because it's a different useSWR key with it's own mutator

brtkx · 2025-09-02T13:36:58Z

packages/arb-token-bridge-ui/src/components/TransactionHistory/useIndexerHistory.ts

+  'addPendingTransaction' | 'updatePendingTransaction'
+> => {
+  const isIndexerEnabled = isExperimentalFeatureEnabled('indexer')
+  // todo: allow undefined in indexer and return empty


useArbitrumIndexer doesn't allow undefined address so we need to pass empty string. Would be nice if indexer let us pass undefined, but it's just nice to have

brtkx · 2025-09-02T13:39:10Z

packages/arb-token-bridge-ui/src/components/TransactionHistory/useIndexerHistory.ts

+    loading: isLoading,
+    // TODO: This will need to be based on pagination
+    completed: !isLoading,
+    failedChainPairs: [],


we can't really do failedChainPairs with indexer

brtkx · 2025-09-02T13:39:33Z

packages/arb-token-bridge-ui/src/components/TransactionHistory/useIndexerHistory.ts

+    completed: !isLoading,
+    failedChainPairs: [],
+    error,
+    pause: () => {},


pause and resume N/A for indexer

brtkx · 2025-09-02T13:40:15Z

packages/arb-token-bridge-ui/src/components/TransactionHistory/useIndexerHistory.ts

+  return {
+    transactions,
+    loading: isLoading,
+    // TODO: This will need to be based on pagination


I don't think we want to do any pagination for v1. We can just fetch first 1000 results like we do for CCTP, and it should be sufficient for vast majority of users for now.

packages/arb-token-bridge-ui/src/components/App/AppProviders.tsx

cla-bot bot added the cla-signed label Jun 25, 2025

vercel bot had a problem deploying to Preview June 25, 2025 13:27 Failure

vercel bot had a problem deploying to Preview June 25, 2025 14:13 Failure

brtkx commented Sep 2, 2025

View reviewed changes

packages/arb-token-bridge-ui/src/components/App/AppProviders.tsx Outdated Show resolved Hide resolved

vercel bot had a problem deploying to Preview September 2, 2025 18:49 Failure

vercel bot had a problem deploying to Preview September 3, 2025 10:51 Failure

brtkx and others added 5 commits September 3, 2025 14:46

init

ef3fa09

indexer

4941474

remove package

4b9a822

fixes

3dbdfe4

yarn link instead

9e7a288

fionnachan changed the base branch from master to bump-react-19 September 3, 2025 13:46

fionnachan force-pushed the indexer-bridge branch from a2f8cac to 9e7a288 Compare September 3, 2025 13:46

vercel bot had a problem deploying to Preview September 3, 2025 13:49 Failure

update @tanstack/react-query

2f32751

vercel bot had a problem deploying to Preview September 3, 2025 15:07 Failure

fionnachan mentioned this pull request Oct 8, 2025

indexer poc WIP OffchainLabs/arbitrum-portal#82

Open

		@@ -0,0 +1,30 @@
		import { createClient } from '@ponder/client'


		type IndexerTransfer = EthIndexerTransfer \| Erc20IndexerTransfer

		function getIndexerTransferStatus(tx: IndexerTransfer) {

feat: indexer poc #2545

Are you sure you want to change the base?

feat: indexer poc #2545

Uh oh!

Conversation

brtkx commented Jun 25, 2025 • edited by fionnachan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brtkx Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

brtkx commented Jun 25, 2025 •

edited by fionnachan

Loading

vercel bot commented Jun 25, 2025 •

edited

Loading

brtkx Sep 2, 2025 •

edited

Loading