feat: show banner for ETH deposits and bump gas #2578
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| // the 30% gas limit increase should cover the difference | ||
| gasLimit: { percentIncrease: BigNumber.from(30) } | ||
| gasLimit: { | ||
| percentIncrease: BigNumber.from(DEFAULT_GAS_PRICE_PERCENT_INCREASE) |
There was a problem hiding this comment.
This is supposed to be used on gas price, not gas limit, so this ain't right. Looks like we already do the same gas price increase in EthDepositStarter.
There was a problem hiding this comment.
Checking if maxFeePerGas to be bumped, and should we bump it in the sdk instead?
brtkx
changed the title
…OffchainLabs/arbitrum-token-bridge into eth-deposit-banner-and-gas-bump
| // the 30% gas limit increase should cover the difference | ||
| gasLimit: { percentIncrease: BigNumber.from(30) } | ||
| gasLimit: { | ||
| percentIncrease: BigNumber.from(DEFAULT_GAS_PRICE_PERCENT_INCREASE) |
There was a problem hiding this comment.
This is supposed to be used on gas price, not gas limit, so this ain't right. Looks like we already do the same gas price increase in EthDepositStarter.
| const hasPendingArbitrumBridgeDeposits = useMemo(() => { | ||
| return transactions.some( | ||
| tx => | ||
| !tx.isWithdrawal && | ||
| isTxPending(tx) && | ||
| getTransactionType(tx) === 'arbitrum' | ||
| ) |
There was a problem hiding this comment.
Should we just simplify this and show it at all times, and maybe alter the message to include something like "If you have pending deposits..."
There was a problem hiding this comment.
I'm not sure about this, because we already have information overload with different banners in transaction history. I think we should only display them to the relevant users.
2 participants
No description provided.